Skip to content

fix: Remove collect, use DoubleEndedIterator #388

fix: Remove collect, use DoubleEndedIterator

fix: Remove collect, use DoubleEndedIterator #388

Triggered via push May 8, 2024 14:05
Status Success
Total duration 3m 59s
Artifacts 1
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 7 warnings
useless conversion to the same type: `impl std::iter::DoubleEndedIterator + std::iter::Iterator<Item = (example_cli::Keychain, bdk_chain::SpkIterator<bdk_chain::miniscript::Descriptor<bdk_chain::miniscript::DescriptorPublicKey>>)> + std::clone::Clone + '_`: example-crates/example_electrum/src/main.rs#L160
error: useless conversion to the same type: `impl std::iter::DoubleEndedIterator + std::iter::Iterator<Item = (example_cli::Keychain, bdk_chain::SpkIterator<bdk_chain::miniscript::Descriptor<bdk_chain::miniscript::DescriptorPublicKey>>)> + std::clone::Clone + '_` --> example-crates/example_electrum/src/main.rs:160:37 | 160 | let keychain_spks = graph | _____________________________________^ 161 | | .index 162 | | .all_unbounded_spk_iters() 163 | | .into_iter() | |________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-D clippy::useless-conversion` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]` help: consider removing `.into_iter()` | 160 ~ let keychain_spks = graph 161 + .index 162 + .all_unbounded_spk_iters() |
useless conversion to the same type: `impl std::iter::DoubleEndedIterator + std::iter::Iterator<Item = (example_cli::Keychain, bdk_chain::SpkIterator<bdk_chain::miniscript::Descriptor<bdk_chain::miniscript::DescriptorPublicKey>>)> + std::clone::Clone + '_`: example-crates/example_electrum/src/main.rs#L160
error: useless conversion to the same type: `impl std::iter::DoubleEndedIterator + std::iter::Iterator<Item = (example_cli::Keychain, bdk_chain::SpkIterator<bdk_chain::miniscript::Descriptor<bdk_chain::miniscript::DescriptorPublicKey>>)> + std::clone::Clone + '_` --> example-crates/example_electrum/src/main.rs:160:37 | 160 | let keychain_spks = graph | _____________________________________^ 161 | | .index 162 | | .all_unbounded_spk_iters() 163 | | .into_iter() | |________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-D clippy::useless-conversion` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]` help: consider removing `.into_iter()` | 160 ~ let keychain_spks = graph 161 + .index 162 + .all_unbounded_spk_iters() |
Code Coverage
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/toolchain@v1, Swatinem/[email protected], actions/setup-python@v4, coverallsapp/github-action@master, actions/upload-artifact@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Code Coverage
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Code Coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Code Coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Code Coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Code Coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "coverage-report". Please update your workflow to use v4 of the artifact actions. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Artifacts

Produced during runtime
Name Size
coverage-report Expired
4.48 MB