Remove basic_json(allocator_type) constructor

danielaparker · Oct 18, 2024 · a0763bf · a0763bf
1 parent c74713b
commit a0763bf
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 21 deletions.
diff --git a/include/jsoncons/basic_json.hpp b/include/jsoncons/basic_json.hpp
@@ -3023,7 +3023,7 @@ namespace jsoncons {
         {
             construct<empty_object_storage>(semantic_tag::none);
         }
-
+/*
         explicit basic_json(const Allocator& alloc) 
         {
             construct<object_storage>(object(alloc), semantic_tag::none);
@@ -3033,7 +3033,7 @@ namespace jsoncons {
         {
             construct<object_storage>(object(alloc), tag);
         }
-
+*/
         basic_json(semantic_tag tag) 
         {
             construct<empty_object_storage>(tag);

diff --git a/test/corelib/src/json_constructor_tests.cpp b/test/corelib/src/json_constructor_tests.cpp
@@ -179,13 +179,6 @@ TEST_CASE("json constructor with pmr allocator")
         CHECK(it != last1);
     }
 
-    SECTION("empty object with given allocator")
-    {
-        jsoncons::pmr::json j1{alloc1};
-        REQUIRE(j1.is_object());
-        REQUIRE(&pool1 == j1.get_allocator().resource());
-    }
-
     SECTION("object move constructor")
     {
         jsoncons::pmr::json j1{jsoncons::json_object_arg, alloc1};
@@ -205,18 +198,6 @@ TEST_CASE("json constructor with pmr allocator")
         CHECK(it != last1);
     }
 
-    SECTION("test 2")
-    {
-        jsoncons::pmr::json j1{ alloc1 };
-
-        j1[long_key1] = long_string1;
-
-        auto it = std::search(buffer1, last1, long_string1, long_string1_end);
-        CHECK(it != last1);
-
-        it = std::search(buffer1, last1, long_key1, long_key1_end);
-        CHECK(it != last1);
-    }
     SECTION("test 3")
     {
         jsoncons::pmr::json j1(long_string1);