Fixed issue #92 #95
Merged
Fixed issue #92 #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgeronimi
changed the title
rgeronimi
changed the title
|
This PR also addresses #93 |
|
Does it satisfy your quality criteria ? I was very careful with the code changes. Don't hesitate if your have any question. |
|
LGTM! Thanks @dmoklaf |
It might be worth opening an issue or PR to discuss this further. |
|
Hi, is this possible to release a new version with this? Thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
#92
Calling nest_asyncio.apply() from this class is useless as it is already called from the base synchronous master object that controls all the API, SemanticScholar.
Successfully tested in both synchronous and asynchronous modes.