Adding badGlobalMuonTagger to ICMuonProducer #167
Conversation
… into HToInv_RDM Conflicts: Analysis/HiggsNuNu/scripts/DefaultLightTreeConfig_data.cfg Analysis/HiggsNuNu/scripts/DefaultLightTreeConfig_mc.cfg Analysis/HiggsNuNu/scripts/submit_lighttree_dataRDM.sh
… into HToInv_RDM Conflicts: Analysis/HiggsNuNu/LightTreeAna/scripts/DefaultRun2Config.cfg
… into HToInv_RDM Conflicts: Analysis/HiggsNuNu/LightTreeAna/test/LTAnalysisRun2_2016.cpp
…_25) for reReco DATA and future MC
H to inv rdm
H to inv rdm
|
please test |
|
The validation server seems to have died again - i'll restart it shortly. But actually I've noticed that you do have some changes to other common code (FnPredicates), so we'll have to hold off from merging until at least Adinda has taken a look to be sure it doesn't affect tautau. This is why it's a good idea to have distinct branches for different developments - it makes it much faster and less painful to get things merged in. Sorry if it seems like I'm being difficult, but everyone has used this approach successfully for a long time now in the group and I think it's important that we continue to follow it. If this update to the muon producer needs to be merged more urgently then it should be straightforward to create a new branch from the common master and cherry pick the relevant commits. |
|
Is that ok if I'm gonna close this PR and make a new one later on, when the code is more stable than now? We changed FnPredicates and other parts of the common code, and I want to be sure of them. |
Hi all,
the only files I changed are:
ICMuonProducer.hh
ICMuonProducer.cc
default_producers_cfi.py
in order to add the badGlobalMuonTagger to the muon producer.
Have i forgotten to change some files?
Please, let me know if this is what you had in mind.