Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2022 ditau #395

Merged
merged 48 commits into from
Oct 2, 2023
Merged

Conversation

ebokor
Copy link
Collaborator

@ebokor ebokor commented Sep 7, 2023

UROP Progress: 2018 vs 2022 Tau data to data analysis and 2022 Run3 analysis

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this one needed still?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this one needed still?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just a modification of HiggsTauTauPlot.py to support Run3 plotting as well? If so then it would be better to merge these changes with the HiggsTauTauPlot.py script to have everything in one place

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to not push this one to the main branch but keep it on our personal branch only

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to not push this one to the main branch but keep it on our personal branch only

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should revert this to the version on the main branch

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to not push this one to the main branch but keep it on our personal branch only

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to not push this one to the main branch but keep it on your personal branch only

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can revert this one to the version on the main branch

@@ -554,11 +568,17 @@ namespace ic {
btag_label = "pfDeepCSVJetTags:probb";
btag_label_extra = "pfDeepCSVJetTags:probbb";
}
if (era_ == era::data_2022_preEE || era_ == era::data_2022_postEE) {
btag_wp = 0.4184;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the b-tag WP cut not be different for 2022?

@@ -585,6 +605,9 @@ namespace ic {
if (era_ == era::data_2018 || era_ == era::data_2018UL) {
deepjet_wp = 0.2770;
}
if (era_ == era::data_2022_preEE || era_ == era::data_2022_postEE) {
deepjet_wp = 0.2770;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this cut not be different for 2022?

@@ -75,6 +75,8 @@ TVector3 GenIP (ic::GenParticle *h, ic::GenParticle *t) {
if(era_ == era::data_2016UL_postVFP) graph_name+="_2016UL_postVFP";
if(era_ == era::data_2017UL) graph_name+="_2017UL";
if(era_ == era::data_2018UL) graph_name+="_2018UL";
if(era_ == era::data_2022_preEE) graph_name+="_2022_preEE";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think we measure this correction for 2022 so this graph should either not get used or pick up the graph used for 2018

@@ -75,6 +75,8 @@ TVector3 GenIP (ic::GenParticle *h, ic::GenParticle *t) {
if(era_ == era::data_2016UL_postVFP) graph_name+="_2016UL_postVFP";
if(era_ == era::data_2017UL) graph_name+="_2017UL";
if(era_ == era::data_2018UL) graph_name+="_2018UL";
if(era_ == era::data_2022_preEE) graph_name+="_2022_preEE";
if(era_ == era::data_2022_postEE) graph_name+="_2022_postEE";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as for L 78

@danielwinterbottom danielwinterbottom merged commit 1ad7908 into danielwinterbottom:UL_ditau Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants