Reuse MinMax algo instead of copy-paste

daniil-lyakhov · Dec 4, 2024 · 8e001e3 · 8e001e3
1 parent 0c406cc
commit 8e001e3
Show file tree

Hide file tree

Showing 9 changed files with 77 additions and 823 deletions.
diff --git a/nncf/experimental/common/quantization/algorithms/post_training/algorithm.py b/nncf/experimental/common/quantization/algorithms/post_training/algorithm.py
@@ -17,7 +17,7 @@
 from nncf.common.tensor_statistics.statistic_point import StatisticPointsContainer
 from nncf.common.utils.backend import BackendType
 from nncf.experimental.common.quantization.algorithms.post_training.pipeline import experimental_create_ptq_pipeline
-from nncf.experimental.common.quantization.algorithms.quantizer.quantizer import NNCFQuantizer
+from nncf.experimental.common.quantization.algorithms.quantizer.base_quantizer import NNCFQuantizer
 from nncf.quantization.advanced_parameters import AdvancedBiasCorrectionParameters
 from nncf.quantization.advanced_parameters import AdvancedSmoothQuantParameters
 from nncf.quantization.advanced_parameters import RangeEstimatorParameters

diff --git a/nncf/experimental/common/quantization/algorithms/post_training/pipeline.py b/nncf/experimental/common/quantization/algorithms/post_training/pipeline.py
@@ -11,7 +11,7 @@
 
 from typing import Optional, TypeVar
 
-from nncf.experimental.common.quantization.algorithms.quantizer.quantizer import NNCFQuantizer
+from nncf.experimental.common.quantization.algorithms.quantizer.base_quantizer import NNCFQuantizer
 from nncf.experimental.common.quantization.algorithms.range_estimator.range_estimator import MinMaxRangeEstimator
 from nncf.quantization.advanced_parameters import AdvancedBiasCorrectionParameters
 from nncf.quantization.advanced_parameters import AdvancedSmoothQuantParameters

diff --git a/...ization/algorithms/quantizer/quantizer.py → ...on/algorithms/quantizer/base_quantizer.py b/...ization/algorithms/quantizer/quantizer.py → ...on/algorithms/quantizer/base_quantizer.py
@@ -22,5 +22,9 @@ class NNCFQuantizer:
     @abstractmethod
     def get_quantization_setup(self, model: TModel, nncf_graph: NNCFGraph) -> SingleConfigQuantizerSetup:
         """
-        Return quantization setup.
+        Builds SingleConfigQuantizerSetup for the given model.
+
+        :param model: Backend-specific model, for which Quantization Target Points are being seek.
+        :param nncf_graph: NNCFGraph instance.
+        :return: SingleConfigQuantizerSetup for the given model.
         """
diff --git a/nncf/experimental/common/quantization/algorithms/quantizer/fx_quantizer.py b/nncf/experimental/common/quantization/algorithms/quantizer/fx_quantizer.py
@@ -29,7 +29,7 @@
 from nncf.common.quantization.quantizer_setup import WeightQuantizationInsertionPoint
 from nncf.common.quantization.structs import QuantizationScheme as QuantizationMode
 from nncf.common.quantization.structs import QuantizerConfig
-from nncf.experimental.common.quantization.algorithms.quantizer.quantizer import NNCFQuantizer
+from nncf.experimental.common.quantization.algorithms.quantizer.base_quantizer import NNCFQuantizer
 
 EdgeOrNode = Union[Tuple[torch.fx.Node, torch.fx.Node]]
 

diff --git a/nncf/experimental/common/quantization/algorithms/range_estimator/backend.py b/nncf/experimental/common/quantization/algorithms/range_estimator/backend.py