Eliminate encoding check in ncnmetric() #2782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dankamongmen
force-pushed
the
dankamongmen/ncmetric
branch
from
e631d68
to
5de00cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a grotesque
pthread_once()+nl_langinfo()inncnmetric(). The alternative would be accepting aconst struct notcurses*(and breaking API). This was broken, as shown in #2779. We want to use the advanced detection mechanisms ofnotcurses_init()andncdirect_init(). Enable this from those functions, then, across the continued lifetime of the process. Document this somewhat unorthodox choice and (possibly) surprising behavior in theBUGSsection ofnotcurses_metric(3).Use
encoding_is_utf8()inncdirect_init().Closes #2779
Closes #2780