Implement _check #21

carlosadames · 2017-11-14T04:59:01Z

This pull request is from issue #1

Optimized export._check() function by deleting duplicate code.

danthareja · 2017-11-14T04:59:06Z

Yay, a pull request!

After you submit a pull request, one of the following will happen:

😭 You don’t get a response. 😭

Even on an active project, it’s possible that your pull request won’t get an immediate response. You should expect some delay as most open source maintainers do so in their free time and can be busy with other tasks.

If you haven’t gotten a response in over a week, it’s fair to politely respond in the same thread, asking someone for a review. If you know the handle of the right person to review your pull request, you can @-mention them to send them a notification. Avoid reaching out to that person privately; remember that public communication is vital to open source projects.

If you make a polite bump and still nobody responds, it’s possible that nobody will respond, ever. It’s not a great feeling, but don’t let that discourage you. It’s happened to everyone! There are many possible reasons why you didn’t get a response, including personal circumstances that may be out of your control. Try to find another project or way to contribute. If anything, this is a good reason not to invest too much time in making a pull request before other community members are engaged and responsive.

🚧 You're asked to make changes to your pull request. 🚧

It’s very common that someone will request changes on your pull request, whether that’s feedback on the scope of your idea, or changes to your code. Often a pull request is just the start of the conversation.

When someone requests changes, be responsive. They’ve taken the time to review your pull request. Opening a PR and walking away is bad form. If you don’t know how to make changes, research the problem, then ask for help if you need it.

If you don’t have time to work on the issue anymore (for example, if the conversation has been going on for months, and your circumstances have changed), let the maintainer know so they’re not expecting a response. Someone else may be happy to take over.

👎 Your pull request doesn’t get accepted. 👎

It's possible your pull request may or may not be accepted in the end. If you’re not sure why it wasn’t accepted, it’s perfectly reasonable to ask the maintainer for feedback and clarification. Ultimately, however, you’ll need to respect that this is their decision. Don’t argue or get hostile. You’re always welcome to fork and work on your own version if you disagree!

🎉 Your pull request gets accepted and merged. 🎉

Hooray! You’ve successfully made an open source contribution!

Thank you for the submission, @carlosadames! I'll review your code shortly, hang tight.

danthareja

Great attempt @carlosadames, you're almost there!

I've marked a few style guide violations with inline comments. Please review the comments below and make the appropriate changes. Remember, you can check your code's style locally with npm run lint.

After you make these changes locally, commit and push them back up to your fork. When you push your changes, I'll come back for another review.

danthareja · 2017-11-14T05:00:54Z

src/calculator.js

-  // Then, invoke this function inside each of the others
-  // HINT: you can invoke this function with exports._check()
-};
+exports._check = (x, y) => {


Block must not be padded by blank lines.

See http://eslint.org/docs/rules/padded-blocks for details about this rule

danthareja · 2017-11-14T05:00:54Z

src/calculator.js

-};
+exports._check = (x, y) => {
+
+    if (typeof x !== 'number') {


Expected indentation of 2 spaces but found 4.

See http://eslint.org/docs/rules/indent for details about this rule

danthareja · 2017-11-14T05:00:54Z

src/calculator.js

+      throw new TypeError(`${x} is not a number`);
+    }
+
+    if (typeof y !== 'number') {


Expected indentation of 2 spaces but found 4.

See http://eslint.org/docs/rules/indent for details about this rule

danthareja · 2017-11-14T05:00:54Z

src/calculator.js

+      throw new TypeError(`${y} is not a number`);
+    }
+
+}


Block must not be padded by blank lines.

See http://eslint.org/docs/rules/padded-blocks for details about this rule

danthareja · 2017-11-14T05:00:54Z

src/calculator.js

+      throw new TypeError(`${y} is not a number`);
+    }
+
+}


Missing semicolon.

See http://eslint.org/docs/rules/semi for details about this rule

danthareja · 2017-11-14T05:00:55Z

src/calculator.js

  return x - y;
+
 };


Block must not be padded by blank lines.

See http://eslint.org/docs/rules/padded-blocks for details about this rule

danthareja · 2017-11-14T05:00:55Z

src/calculator.js

  return x * y;
+
 };


Block must not be padded by blank lines.

See http://eslint.org/docs/rules/padded-blocks for details about this rule

danthareja · 2017-11-14T05:00:55Z

src/calculator.js

  return x * y;
+
 };

 exports.divide = (x, y) => {


Block must not be padded by blank lines.

See http://eslint.org/docs/rules/padded-blocks for details about this rule

danthareja · 2017-11-14T05:00:55Z

src/calculator.js

-  if (typeof y !== 'number') {
-    throw new TypeError(`${y} is not a number`);
-  }
+


Trailing spaces not allowed.

See http://eslint.org/docs/rules/no-trailing-spaces for details about this rule

danthareja · 2017-11-14T05:00:55Z

src/calculator.js

  return x / y;
+
 };


Block must not be padded by blank lines.

See http://eslint.org/docs/rules/padded-blocks for details about this rule

danthareja · 2017-11-14T05:19:31Z

✨ Changes synced ✨

When a pull request is open, GitHub tracks changes to the branch it was opened from. As you push changes to your fork's master branch, you'll automatically see them here.

I'm reviewing your changes now, @carlosadames. Let's get this merged soon!

danthareja

All of the tests are passing and the code is clean.

This is a huge improvment for our codebase's maintainability. The team is going to be stoked to see your contribution when they get back from vacation.

Well done, @carlosadames 👏

danthareja · 2017-11-14T05:21:28Z

🎉 You did it! 🎉

You're an open source contributor now!

Whether this was your first pull request, or you’re just looking for new ways to contribute, I hope you’re inspired to take action. Don't forget to say thanks when a maintainer puts effort into helping you, even if a contribution doesn't get accepted.

Open source is made by people like you: one issue, pull request, comment, and +1 at a time.

What's next?

Find your next project:

First Timers Only - a site dedicated to helping new contributors
YourFirstPR - a site showcasing starter issues on GitHub
awesome-for-beginners - a list of projects with good starter issues
Issuehub.io - a tool for searching GitHub issues by label and language

Learn from other great community members:

git-it-electron - a desktop app for learning Git and GitHub by @jlord
first-contributions - an educational project by @Roshanjossey
"How to contribute to an open source project on github" - a video series by @kentcdodds
"How to Contribute to Open Source" - a written guide by @Github

Elevate your Git game:

Try Git - an interactive tutorial made by GitHub
Learn Git - video and written lessons for the command line and desktop client
Learn Git Branching - an interactive tutorial diving deep into branching
GitHub Flow - a video video explaining the pull request process on GitHub

Questions? Comments? Concerns?

I'm always open to feedback. If you had a good time with the exercise, or found some room for improvement, please let me know on twitter or email.

Want to start over? Just delete your fork.
Want to see behind the scenes?

danthareja · 2018-01-31T00:21:37Z

Hello again, @carlosadames! I want to congratulate you again for completing this challenge. Hopefully you've started to get out there and apply your knowledge to another project.

Since you haven't pushed a commit in a while, I'm going to delete your branch in order to make room for others actively particiating. You'll still have access to your fork, but you won't be able to submit anymore pull requests to this branch.

Don't worry though! If you decide that you do want a new branch, you can delete your fork and re-fork the original project.

Happy Hacking!

ingcadames added 2 commits November 14, 2017 04:23

Implement _check

cb6ce5b

Changed describe.only to describe in src/calculator.test.js

9bf7571

danthareja requested changes Nov 14, 2017

View reviewed changes

fixed some style guide violations detected by lint

53c28a1

danthareja approved these changes Nov 14, 2017

View reviewed changes

danthareja merged commit 64b67c1 into danthareja:carlosadames Nov 14, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement _check #21

Implement _check #21

carlosadames commented Nov 14, 2017

danthareja commented Nov 14, 2017

Yay, a pull request!

😭 You don’t get a response. 😭

🚧 You're asked to make changes to your pull request. 🚧

👎 Your pull request doesn’t get accepted. 👎

🎉 Your pull request gets accepted and merged. 🎉

danthareja left a comment

danthareja Nov 14, 2017

danthareja Nov 14, 2017

danthareja Nov 14, 2017

danthareja Nov 14, 2017

danthareja Nov 14, 2017

danthareja Nov 14, 2017

danthareja Nov 14, 2017

danthareja Nov 14, 2017

danthareja Nov 14, 2017

danthareja Nov 14, 2017

danthareja commented Nov 14, 2017

danthareja left a comment

danthareja commented Nov 14, 2017

danthareja commented Jan 31, 2018

Implement _check #21

Implement _check #21

Conversation

carlosadames commented Nov 14, 2017

danthareja commented Nov 14, 2017

Yay, a pull request!

😭 You don’t get a response. 😭

🚧 You're asked to make changes to your pull request. 🚧

👎 Your pull request doesn’t get accepted. 👎

🎉 Your pull request gets accepted and merged. 🎉

danthareja left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

See http://eslint.org/docs/rules/padded-blocks for details about this rule

Choose a reason for hiding this comment

See http://eslint.org/docs/rules/indent for details about this rule

Choose a reason for hiding this comment

See http://eslint.org/docs/rules/indent for details about this rule

Choose a reason for hiding this comment

See http://eslint.org/docs/rules/padded-blocks for details about this rule

Choose a reason for hiding this comment

See http://eslint.org/docs/rules/semi for details about this rule

Choose a reason for hiding this comment

See http://eslint.org/docs/rules/padded-blocks for details about this rule

Choose a reason for hiding this comment

See http://eslint.org/docs/rules/padded-blocks for details about this rule

Choose a reason for hiding this comment

See http://eslint.org/docs/rules/padded-blocks for details about this rule

Choose a reason for hiding this comment

See http://eslint.org/docs/rules/no-trailing-spaces for details about this rule

Choose a reason for hiding this comment

See http://eslint.org/docs/rules/padded-blocks for details about this rule

danthareja commented Nov 14, 2017

danthareja left a comment

Choose a reason for hiding this comment

danthareja commented Nov 14, 2017

🎉 You did it! 🎉

What's next?

Questions? Comments? Concerns?

danthareja commented Jan 31, 2018