Implement _check #2282
Implement _check #2282
Conversation
There was a problem hiding this comment.
This is a great attempt, @paritosh142!
I would like to request a few changes before merging your work. Please review my comments below and make the appropriate changes to your code.
After you update your code locally, follow the instructions to save your changes locally and push your changes to your fork.
When you push your changes to your fork, I'll come back for another review.
There are 36 style guide violations in your contribution. I've marked them with inline comments for your convenience.
Please revisit your code and follow the style guide best practices.
Hint: You might be able to fix some issues automatically by running npm run lint -- --fix
All the tests are passing. Nice job!
| // Then, invoke this function inside each of the others | ||
| // HINT: you can invoke this function with exports._check() | ||
| exports._check = (x, y) => { | ||
| if (typeof x !== "number") throw new TypeError(`${x} is not a number`); |
There was a problem hiding this comment.
Strings must use singlequote.
(learn more)
| exports._check = (x, y) => { | ||
| if (typeof x !== "number") throw new TypeError(`${x} is not a number`); | ||
|
|
||
| if (typeof y !== "number") throw new TypeError(`${y} is not a number`); |
There was a problem hiding this comment.
Strings must use singlequote.
(learn more)
| @@ -1,20 +1,20 @@ | |||
| /* eslint-disable no-unused-expressions */ | |||
| const calculator = require('./calculator'); | |||
| const calculator = require("./calculator"); | |||
There was a problem hiding this comment.
Strings must use singlequote.
(learn more)
|
|
||
| describe.skip('_check', () => { | ||
| describe("_check", () => { |
There was a problem hiding this comment.
Strings must use singlequote.
(learn more)
| beforeEach(() => { | ||
| sinon.spy(calculator, '_check'); | ||
| sinon.spy(calculator, "_check"); |
There was a problem hiding this comment.
Strings must use singlequote.
(learn more)
| describe('subtract', () => { | ||
| it('should throw a TypeError if arguments are not numbers', () => { | ||
| expect(() => calculator.subtract(40, '2')).to.throw(TypeError); | ||
| describe("subtract", () => { |
There was a problem hiding this comment.
Strings must use singlequote.
(learn more)
| it('should throw a TypeError if arguments are not numbers', () => { | ||
| expect(() => calculator.subtract(40, '2')).to.throw(TypeError); | ||
| describe("subtract", () => { | ||
| it("should throw a TypeError if arguments are not numbers", () => { |
There was a problem hiding this comment.
Strings must use singlequote.
(learn more)
| expect(() => calculator.subtract(40, '2')).to.throw(TypeError); | ||
| describe("subtract", () => { | ||
| it("should throw a TypeError if arguments are not numbers", () => { | ||
| expect(() => calculator.subtract(40, "2")).to.throw(TypeError); |
There was a problem hiding this comment.
Strings must use singlequote.
(learn more)
| expect(() => calculator.subtract(40, [])).to.throw(TypeError); | ||
| expect(() => calculator.subtract(40, {})).to.throw(TypeError); | ||
| expect(() => calculator.subtract('40', 2)).to.throw(TypeError); | ||
| expect(() => calculator.subtract("40", 2)).to.throw(TypeError); |
There was a problem hiding this comment.
Strings must use singlequote.
(learn more)
| expect(() => calculator.subtract([], 2)).to.throw(TypeError); | ||
| expect(() => calculator.subtract({}, 2)).to.throw(TypeError); | ||
| }); | ||
|
|
||
| it('should subtract two positive numbers', () => { | ||
| it("should subtract two positive numbers", () => { |
There was a problem hiding this comment.
Strings must use singlequote.
(learn more)
Description
Refactored the calculator operations (
add,subtract,multiply,divide) to use the_checkfunction for type checking. This removes redundancy and improves code maintainability.Changes
_checkfunction insrc/calculator.js_checkfor type validationsrc/calculator.test.jsto reflect the changesTesting
npm testto ensure all tests pass