-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to 3box comments #1651
Switch to 3box comments #1651
Conversation
TODO: figure out why the loginFunction doesnt work for the 3box comments box, so we dont have to our own login button and can show the comments without them logging in. Seems to be a bug? 3box/3box-comments-react#31
Only finished on the ProposalDetailsPage so far
This is working pretty well for me right now (https://alchemy-staging-kovan.herokuapp.com/). Though it's actually on rinkeby, not kovan? The styling of the warning ("We are moving from Disqus to 3Box...") is a bit strange, but I'm assuming we'll remove that in a couple weeks anyway. |
TODO: figure out why the loginFunction doesnt work for the 3box comments box, so we dont have to our own login button and can show the comments without them logging in. Seems to be a bug? 3box/3box-comments-react#31
Only finished on the ProposalDetailsPage so far
Note: apparently [email protected] does not work with [email protected]. They say they will be updating it "today". [UPDATE]: They released the upgrade and I've pulled it in. Note [email protected] also purports to solve the huge package/slug size problem |
Just a note: 3Box has some absolutely horrible CSS in the UI it injects into Alchemy, reflected in the layout issues I'm reporting in the PR. I'm having to hack some CSS overrides. (classic issues with use of CSS absolute positioning.) |
ea0f75a
to
38e1ada
Compare
3box is hanging in the call to [UPDATE:] They are suggesting the "infrastructure instability" should be resolved "Today or tomorrow hopefully, we are still debugging it." [UPDATE2]: Appears to be fixed with the repairs to their infrastructure. |
I have been informed by 3box that 3box-comments-react is only barely being supported at the moment. |
Upon an account's first attempt to enter a comment, the entire process requires four prompts for a signature, half of which seem to be redundant, and a couple fairly long pauses in rinkeby which I expect will be even longer on mainnet. |
STEPS:
RESULT: The new comment shows up as having been submitted by account 1 EXPECT: Should show the comment as having been created by account 2 |
Closing, we will start from scratch using 3Box Threads |
Fixes #1553