Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to 3box comments #1651

Closed
wants to merge 42 commits into from
Closed

Switch to 3box comments #1651

wants to merge 42 commits into from

Conversation

tibetsprague
Copy link
Contributor

@tibetsprague tibetsprague commented May 1, 2020

Fixes #1553

  • removes App.spec.ts because it was failing due to this error. It contained no tests anyway. And merely attempting to import a react component in the absence of a browser seems like a weird thing to do.

TODO: figure out why the loginFunction doesnt work for the 3box comments box, so we dont have to our own login button and can show the comments without them logging in. Seems to be a bug? 3box/3box-comments-react#31
Only finished on the ProposalDetailsPage so far
@tibetsprague tibetsprague marked this pull request as ready for review May 1, 2020 20:30
@dkent600 dkent600 self-assigned this May 4, 2020
@dkent600 dkent600 changed the title Work in progress to switch to 3box comments Switch to 3box comments May 4, 2020
@dkent600 dkent600 requested review from dkent600 and orenyodfat May 4, 2020 14:58
@dkent600 dkent600 temporarily deployed to alchemy-1553-3box-comme-jrhmrk May 4, 2020 14:59 Inactive
@orenyodfat orenyodfat temporarily deployed to alchemy-1553-3box-comme-b9ondj May 4, 2020 21:00 Inactive
@dkent600 dkent600 mentioned this pull request May 4, 2020
@orenyodfat orenyodfat temporarily deployed to alchemy-1553-3box-comme-b0gaql May 4, 2020 21:16 Inactive
@orenyodfat orenyodfat temporarily deployed to alchemy-1553-3box-comme-wu2ypc May 4, 2020 21:33 Inactive
@orenyodfat orenyodfat temporarily deployed to alchemy-staging-kovan May 6, 2020 13:39 Inactive
@orenyodfat orenyodfat temporarily deployed to alchemy-1553-3box-comme-qeutaf May 6, 2020 17:24 Inactive
@EzraWeller
Copy link
Contributor

This is working pretty well for me right now (https://alchemy-staging-kovan.herokuapp.com/). Though it's actually on rinkeby, not kovan?

The styling of the warning ("We are moving from Disqus to 3Box...") is a bit strange, but I'm assuming we'll remove that in a couple weeks anyway.

@orenyodfat orenyodfat temporarily deployed to alchemy-1553-3box-comme-a257qo May 7, 2020 12:31 Inactive
tibetsprague and others added 8 commits May 7, 2020 17:14
TODO: figure out why the loginFunction doesnt work for the 3box comments box, so we dont have to our own login button and can show the comments without them logging in. Seems to be a bug? 3box/3box-comments-react#31
Only finished on the ProposalDetailsPage so far
@dkent600 dkent600 temporarily deployed to alchemy-1553-3box-comme-whpzyd June 17, 2020 17:12 Inactive
@dkent600 dkent600 temporarily deployed to alchemy-1553-3box-comme-whpzyd June 17, 2020 19:04 Inactive
@dkent600 dkent600 temporarily deployed to alchemy-1553-3box-comme-whpzyd June 17, 2020 19:19 Inactive
@dkent600
Copy link
Contributor

dkent600 commented Jun 18, 2020

Note: apparently [email protected] does not work with [email protected]. They say they will be updating it "today".

[UPDATE]: They released the upgrade and I've pulled it in. Note [email protected] also purports to solve the huge package/slug size problem

@dkent600
Copy link
Contributor

dkent600 commented Jun 18, 2020

3BOX label to the right of the edit box, that shows when the spinner is there, is too far to the right and also causes a horizontal scrollbar to appear

image

@dkent600
Copy link
Contributor

dkent600 commented Jun 18, 2020

Just a note: 3Box has some absolutely horrible CSS in the UI it injects into Alchemy, reflected in the layout issues I'm reporting in the PR. I'm having to hack some CSS overrides. (classic issues with use of CSS absolute positioning.)

@dkent600 dkent600 temporarily deployed to alchemy-1553-3box-comme-whpzyd June 18, 2020 14:15 Inactive
@dkent600 dkent600 temporarily deployed to alchemy-1553-3box-comme-whpzyd June 18, 2020 14:20 Inactive
@dkent600 dkent600 temporarily deployed to alchemy-1553-3box-comme-whpzyd June 18, 2020 14:43 Inactive
@dkent600 dkent600 temporarily deployed to alchemy-1553-3box-comme-whpzyd June 18, 2020 16:15 Inactive
@dkent600 dkent600 force-pushed the 1553-3box-comments branch from ea0f75a to 38e1ada Compare June 19, 2020 18:23
@dkent600 dkent600 temporarily deployed to alchemy-1553-3box-comme-whpzyd June 19, 2020 18:23 Inactive
@dkent600 dkent600 temporarily deployed to alchemy-1553-3box-comme-whpzyd June 19, 2020 22:44 Inactive
@dkent600
Copy link
Contributor

dkent600 commented Jun 22, 2020

3box is hanging in the call to box.auth. At best it occasionally returns, but after minutes. This could account for the hangs I reported in other comments above. I have reported it to 3box in a ticket here: 3box/3box-js#848

[UPDATE:] They are suggesting the "infrastructure instability" should be resolved "Today or tomorrow hopefully, we are still debugging it."

[UPDATE2]: Appears to be fixed with the repairs to their infrastructure.

@dkent600
Copy link
Contributor

I have been informed by 3box that 3box-comments-react is only barely being supported at the moment.

@dkent600
Copy link
Contributor

dkent600 commented Jul 2, 2020

Upon an account's first attempt to enter a comment, the entire process requires four prompts for a signature, half of which seem to be redundant, and a couple fairly long pauses in rinkeby which I expect will be even longer on mainnet.

@dkent600
Copy link
Contributor

dkent600 commented Jul 2, 2020

STEPS:

  1. create a comment in account 1
  2. in Metamask, switch to account 2. Observe 3Box now displays the identity of account 2 above the comment box
  3. create another comment

RESULT:

The new comment shows up as having been submitted by account 1

EXPECT:

Should show the comment as having been created by account 2

@dkent600 dkent600 added the 1.0 label Jul 25, 2020
@dkent600
Copy link
Contributor

Closing, we will start from scratch using 3Box Threads

@dkent600 dkent600 closed this Jul 27, 2020
@orenyodfat orenyodfat deleted the 1553-3box-comments branch November 2, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3box comment threads
4 participants