fix: fixed integration tests and selenium version #36
Conversation
Razzwan
force-pushed
the
merge-dev
branch
2 times, most recently
from
8cf66d4 to
facba62
Compare
|
|
||
| describe("Token Trade Proposals", () => { | ||
| let daoAddress: string; | ||
| let addresses: ITestAddresses; | ||
| let addresses: any; |
There was a problem hiding this comment.
@roienatan because interface is incorrect and it lead typescript checks issue. Proper way is just fix interface I gues...
There was a problem hiding this comment.
@roienatan trying to fix, but interface is deeply different. Code works properly, but we don't have correct interface for it
test/integration/tsconfig.json
Outdated
| "moduleResolution": "node", | ||
| "declaration": true, | ||
| "declarationDir": "../dist/types", | ||
| "removeComments": true, |
There was a problem hiding this comment.
this reduce bundle size?
There was a problem hiding this comment.
@orenyodfat hm... actually no. Bundle doesn't contain integration tests. I just copied this config from documentation. I can remove it. It is redundant and doesn't do anything useful
There was a problem hiding this comment.
@orenyodfat removed because of redundant
|
Is it normal that there is one check here? (instead of two checks) |
It is because of no branch exists at the same repo. I created PR from fork, because I had no access to this repo. So, just only PR checked, no branch. Actually, we should rather skip second check for all our requests, because one of them is redundant |
No description provided.