save cap on storage #264
Merged
save cap on storage #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should be fixed here: https://github.com/dapperlabs/nba-smart-contracts/pull/263/files |
joshuahannan
approved these changes
Aug 29, 2024
judezhu
added a commit
that referenced
this pull request
Sep 3, 2024
* first version of cadence 1.0 * Add minter entitlement and inherity NFT public interface in TopShot public interface * update go version * Swith view and access positions * Adjust smart contracts for cadence 1.0 * fix contracts test * nft v1.0.0 upgrade (#252) * cadence 1 upgrade * fix tests * token updated * sharded collection conforming to NFT provider and deposit * remove contract initialized * update fastbreakv1 * Bump golang.org/x/net from 0.19.0 to 0.23.0 in /lib/go/test (#250) * Bump golang.org/x/net from 0.19.0 to 0.23.0 in /lib/go/test Bumps [golang.org/x/net](https://github.com/golang/net) from 0.19.0 to 0.23.0. - [Commits](golang/net@v0.19.0...v0.23.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * generated --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Taylor Petrychyn <[email protected]> * upgrade flow sdk * fix minted event * updated go mod * Fix tests on Cadence 1.0 (#255) * Fix tests * ci * Update go version * remove contract initialized * fix get length * remove unneeded entitlement * emit standard events * deprecate public interface * Re-add public interfaces now due to usage in tests; remove un-needed nftUpdated event call, as it was already being called * update assets * remove Withdraw / Deposit events from Fastbreak in lieu of standard NFT events * update readme * Remove custom Withdraw / Deposit events being emitted * update assets * fix tests * fix more tests * remove unused code * added events validateion * updated all event type check * fix fields * fixed id * fix unlock event * fixed moment minted * added new name * add script to setup capabilities on minter account from locker account * Embed transactions / scripts (#260) * update assets * update commit * fix script * run make test * fix marketplace txes * revert hardcoded address * fix addresses * updated assets * fix tx * updated assets * fix script * save cap on storage (#264) * save cap on storage * fix var / entitlements * add comments and V1 Sale handling to create and start sale collection (#266) --------- Co-authored-by: Joshua Hannan <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Eric Ren <[email protected]> Co-authored-by: Fabio Kenji <[email protected]> Co-authored-by: Jude Zhu <[email protected]> Co-authored-by: Jude Zhu <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Taylor Petrychyn <[email protected]> Co-authored-by: Joshua Hannan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.