Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update create and start V3 sale collection transaction #266

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Update create and start V3 sale collection transaction #266

merged 1 commit into from
Aug 30, 2024

Conversation

joshuahannan
Copy link
Contributor

  • Adds comments to the transaction to make sure everything that the transaction is doing is clear.
  • Update V1 Sale handling to make sure that no capability is created if the account doesn't have a V1 Sale Collection already
  • Add some extra error messages for cases when capabilities don't exist

@joshuahannan joshuahannan requested a review from a team as a code owner August 29, 2024 17:25
@joshuahannan joshuahannan changed the base branch from master to fkenji/fix-issue-cap August 29, 2024 17:26
@joshuahannan joshuahannan requested a review from fkenji August 29, 2024 17:39
@fkenji fkenji merged commit 0dddd85 into fkenji/fix-issue-cap Aug 30, 2024
1 check passed
fkenji added a commit that referenced this pull request Aug 30, 2024
@fkenji @joshuahannan
save cap on storage (#264)
b42875f 
* save cap on storage

* fix var / entitlements

* add comments and V1 Sale handling to create and start sale collection (#266)

---------

Co-authored-by: Joshua Hannan <[email protected]>
judezhu added a commit that referenced this pull request Sep 3, 2024
@bshahid331 @rrrkren
@fkenji @judezhu @dependabot @tpetrychyn @joshuahannan
Update NBA contracts & txs to Cadence 1.0 (#248)
96b859a 
* first version of cadence 1.0

* Add minter entitlement and inherity NFT public interface in TopShot public interface

* update go version

* Swith view and access positions

* Adjust smart contracts for cadence 1.0

* fix contracts test

* nft v1.0.0 upgrade (#252)

* cadence 1 upgrade

* fix tests

* token updated

* sharded collection conforming to NFT provider and deposit

* remove contract initialized

* update fastbreakv1

* Bump golang.org/x/net from 0.19.0 to 0.23.0 in /lib/go/test (#250)

* Bump golang.org/x/net from 0.19.0 to 0.23.0 in /lib/go/test

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.19.0 to 0.23.0.
- [Commits](golang/net@v0.19.0...v0.23.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* generated

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Taylor Petrychyn <[email protected]>

* upgrade flow sdk

* fix minted event

* updated go mod

* Fix tests on Cadence 1.0 (#255)

* Fix tests

* ci

* Update go version

* remove contract initialized

* fix get length

* remove unneeded entitlement

* emit standard events

* deprecate public interface

* Re-add public interfaces now due to usage in tests; remove un-needed nftUpdated event call, as it was already being called

* update assets

* remove Withdraw / Deposit events from Fastbreak in lieu of standard NFT events

* update readme

* Remove custom Withdraw / Deposit events being emitted

* update assets

* fix tests

* fix more tests

* remove unused code

* added events validateion

* updated all event type check

* fix fields

* fixed id

* fix unlock event

* fixed moment minted

* added new name

* add script to setup capabilities on minter account from locker account

* Embed transactions / scripts (#260)

* update assets

* update commit

* fix script

* run make test

* fix marketplace txes

* revert hardcoded address

* fix addresses

* updated assets

* fix tx

* updated assets

* fix script

* save cap on storage (#264)

* save cap on storage

* fix var / entitlements

* add comments and V1 Sale handling to create and start sale collection (#266)

---------

Co-authored-by: Joshua Hannan <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Eric Ren <[email protected]>
Co-authored-by: Fabio Kenji <[email protected]>
Co-authored-by: Jude Zhu <[email protected]>
Co-authored-by: Jude Zhu <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Taylor Petrychyn <[email protected]>
Co-authored-by: Joshua Hannan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkenji fkenji fkenji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshuahannan @fkenji