Refactor useEffect

dappforce · Jul 4, 2024 · bf67949 · bf67949
1 parent 9876b5b
commit bf67949
Showing 1 changed file with 10 additions and 12 deletions.
diff --git a/src/components/modals/LinkEvmAddressModal.tsx b/src/components/modals/LinkEvmAddressModal.tsx
@@ -23,20 +23,18 @@ export default function LinkEvmAddressModal(
 
   const { evmAddress: myEvmAddress } = useLinkedEvmAddress()
   useEffect(() => {
-    if (props.isOpen && myEvmAddress && !isAfterSubmit.current) {
-      setEvmAddress(myEvmAddress)
-      reset()
-      isAfterSubmit.current = false
-    }
-  }, [props.isOpen, myEvmAddress, reset])
-
-  useEffect(() => {
-    if (props.isOpen && isAfterSubmit.current) {
-      props.closeModal()
-      isAfterSubmit.current = false
+    if (props.isOpen && myEvmAddress) {
+      if (!isAfterSubmit.current) {
+        setEvmAddress(myEvmAddress)
+        reset()
+        isAfterSubmit.current = false
+      } else {
+        props.closeModal()
+        isAfterSubmit.current = false
+      }
     }
     // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [myEvmAddress, props.isOpen])
+  }, [props.isOpen, myEvmAddress, reset])
 
   const onSubmit = (e: any) => {
     e.preventDefault()