Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from docker-compose to docker compose #598

Merged
merged 6 commits into from
Feb 16, 2024

Conversation

3alpha
Copy link
Member

@3alpha 3alpha commented Nov 28, 2023

As docker-compose is deprecated, we must migrate to docker compoe command eventually.

This shouldn't have too much impact on overall system as majority of complexity of compose handling is done inside DAppManager which as its own binary, we still must be very careful about making this change.

That is the reason I added script which would make "alias" to docker-compose so we don't inadvertanly break any functionality.

I have tested this but thorough testing of this should be done as it is critical to the functionality of whole system.

@3alpha 3alpha requested a review from a team as a code owner November 28, 2023 19:23
@3alpha 3alpha changed the title Migrate from docker-compose to docker-compose Migrate from docker-compose to docker compose Nov 28, 2023
dappnodedev
dappnodedev previously approved these changes Dec 11, 2023
@dappnodedev
Copy link
Contributor

I have tested fresh install on a NUC 13 and docker installation has been successful. However, we need to fix bind compose, as dncore_network seems to be causing an error due to it not existing before trying to start bind containers

@dappnodedev
Copy link
Contributor

The issue with bind has been fixed after Bind v0.2.7 has been released

dappnodedev
dappnodedev previously approved these changes Dec 14, 2023
@pablomendezroyo pablomendezroyo merged commit fb19ee5 into master Feb 16, 2024
6 checks passed
@pablomendezroyo pablomendezroyo deleted the 3alpha/migrate-compose branch February 16, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants