Fix fullnode.dappnode alias
#1640
Conversation
|
DAppNode bot has built and pinned the release to an IPFS node, for commit: 2b7e9e5 This is a development version and should only be installed for testing purposes, install link (by dappnodebot/build-action) |
dappnodedev
force-pushed
the
dappnodedev/fix-fullnode
branch
2 times, most recently
from
b2270e7 to
f365d21
Compare
| removeAlias: boolean; | ||
| prevExecClientDnpName?: ExecutionClient<T>; | ||
| newExecClientDnpName?: ExecutionClient<T>; | ||
| network?: T; |
There was a problem hiding this comment.
why is network optional and default to mainnet? wouldnt it be better to make it explicitly clear what network we want and make it a mandatory parameter?
There was a problem hiding this comment.
I chose to do it in this way because "mainnet" is the actual purpose of the fullnode functionality and before we did not consider fullnode domain in other networks so it should be the main one
There was a problem hiding this comment.
If we were ever to move our repo to Gnosis Chain or to zkEVM - to save Gas on publishing new packages - , what would be the way to implement the network parameter and the defaults? I would consider this question to decide on the implementation.
There was a problem hiding this comment.
If we do that, I am afraid the name of the domain is the least of our problems :/
dappnodedev
force-pushed
the
dappnodedev/fix-fullnode
branch
from
6856d4c to
1304eb9
Compare
dappnodedev
force-pushed
the
dappnodedev/fix-fullnode
branch
from
1304eb9 to
2b7e9e5
Compare
|
As a side note, |
fullnode.dappnodedomain should point to the mainnet execution selected by the user, if anyAlso, each network (prater, gnosis and lukso) has its own fullnode domain, following this pattern:
<network>.fullnode.dappnode