Remove bind as DNS server from compose files #1646
Conversation
|
DAppNode bot has built and pinned the release to an IPFS node, for commit: 8f9dd3b This is a development version and should only be installed for testing purposes, install link (by dappnodebot/build-action) |
|
Is it documented somewhere the work of stopping from adding the bind to the compose file? |
|
Testing needs to be added here before merging |
| const composeService = services[serviceName].get(); | ||
| if (composeService.dns) { | ||
| logs.info(`Removing DNS from ${serviceName} in ${dnpName} compose file`); | ||
| composeService.dns = undefined; |
There was a problem hiding this comment.
Are you sure this instructions completely removes the dns field?
There was a problem hiding this comment.
Yes! This will remove the dns field from every docker-compose.yml file that still includes it
| composeAlreadyMigrated | ||
| ); | ||
| // Redeclare global variables | ||
| params.DNCORE_DIR = composeDnsRemovalTestPath; |
There was a problem hiding this comment.
You should not have to do this, the env TEST=true should change the dirs already allowing you to test propertly
| aliases: | ||
| - ${serviceName}.test-migration.dappnode | ||
| - ${serviceName}.dappnode`; | ||
|
|
||
| const composeAlreadyMigrated = ` |
There was a problem hiding this comment.
Now that this file has alias migration and dns migration tests, I would rename:
composeAlreadyMigrated to composeAliasesToBeMigrated
composeToBeMigratedBefore to composeAliasesAlreadyMigrated
Or something like that, so we know that these are used for alias migration and not DNS
| }); | ||
|
|
||
| it("Should remove DNS from compose file", async () => { | ||
| removeDnsFromPackageComposeFile(container.dnpName, false); |
There was a problem hiding this comment.
should we test also the removeDnsFromPackageComposeFile for core packages or is not worth it?
This is the first step to take in the dappmanager towards current Bind functionality removal