Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create types module #1807

Merged
merged 4 commits into from
Jan 25, 2024
Merged

Create types module #1807

merged 4 commits into from
Jan 25, 2024

Conversation

pablomendezroyo
Copy link
Contributor

@pablomendezroyo pablomendezroyo commented Jan 24, 2024

Create types module, extracted types from existing module common and used where needed. Required to have toolkit and schemas modules modularized allowing to publish these dependencies to avoid code duplication in sdk

@pablomendezroyo pablomendezroyo requested a review from a team as a code owner January 24, 2024 12:12
@github-actions github-actions bot temporarily deployed to commit January 24, 2024 12:16 Inactive
Copy link

github-actions bot commented Jan 24, 2024

Copy link

github-actions bot commented Jan 24, 2024

DAppNode bot has built and pinned the release to an IPFS node, for commit: b28a914

This is a development version and should only be installed for testing purposes, install link

/ipfs/QmU5FB14XxPReZuPPES4KeqM4d6bgMor7nWP9RKM4SNXN1

(by dappnodebot/build-action)

@github-actions github-actions bot temporarily deployed to commit January 25, 2024 10:12 Inactive
@github-actions github-actions bot temporarily deployed to commit January 25, 2024 10:18 Inactive
@pablomendezroyo pablomendezroyo changed the title Remove internal dependencies from toolkit Create types module Jan 25, 2024
@github-actions github-actions bot temporarily deployed to commit January 25, 2024 10:31 Inactive
@pablomendezroyo pablomendezroyo merged commit e5db5bd into develop Jan 25, 2024
8 checks passed
@pablomendezroyo pablomendezroyo deleted the pablo/modularize-toolkit branch January 25, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant