Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs #1994

Merged
merged 4 commits into from
Jul 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@

## Test instructions

<!-- MANDATORY: please, do not skip this step, it is very importand for DAppNode team to have simple and well defined instructions on how to test this PR.
<!-- MANDATORY: please, do not skip this step, it is very important for DAppNode team to have simple and well defined instructions on how to test this PR.
-->
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ yarn start

_Note: This mode is not working a the moment since cross-domain cookies are not enabled._

4. Docker real-time development (Recomended).
4. Docker real-time development (recommended).

SSH into your Dappnode and clone this repo:

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { MockDnp } from "./dnps/types";
import { mockDnps } from "./dnps";

// The functions: getContainerName, getContainerDomain and getImageTag are utility functions from the module @dappnode/utils
// they are used in the server mock, and to avoid compiling issues due to not able to use node modules in the browser
// they are used in the server mock, and to avoid compiling issues due to not being able to use node modules in the browser
// they are copied here

// TODO: either export them from uitls in a subpath separately or find a way to use them in the browser without duplicating them
Expand Down
2 changes: 1 addition & 1 deletion packages/admin-ui/src/api/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ export const api: Routes = mapValues(

/**
* React hook to perform RPC calls on component mount
* Usefull to keep track of changing data that may need to be revalidated
* Useful to keep track of changing data that may need to be revalidated
*/
export const useApi: {
[K in keyof Routes]: (
Expand Down
Loading