Improve port mapping warnings/errors #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dappnode bot has built and pinned the built packages to an IPFS node, for commit: 5f005f6 This is a development version and should only be installed for testing purposes.
Hash: (by dappnodebot/build-action) |
dappnodedev
reviewed
Sep 2, 2024
packages/admin-ui/src/pages/packages/components/Network/PortsByService.tsx
Outdated
Show resolved
Hide resolved
dappnodedev
reviewed
Sep 2, 2024
packages/admin-ui/src/pages/packages/components/Network/PortsByService.tsx
Outdated
Show resolved
Hide resolved
dappnodedev
approved these changes
Sep 2, 2024
3alpha
approved these changes
Sep 2, 2024
pablomendezroyo
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dappmanager didnt let user map a new port if it was in the ephemeral range (32768-65535). These are ports used normally for a short period of time.
Now, only a warning is displayed if a port is in this range. An exception is made for 51820, which is the default Wireguard port, hardcoded by us.
See table where wireguard port 51820 is acknowledged: https://en.wikipedia.org/wiki/List_of_TCP_and_UDP_port_numbers#Dynamic,_private_or_ephemeral_ports
DNP_WIREGUARD port config: https://github.com/dappnode/DNP_WIREGUARD/blob/4a074010c98b5d3003d1c3306edcb75392b247f4/docker-compose.yml#L17
Also, if user tries to map a port > max port number (65535), the "update port mappings" button is disabled.