Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement bacwards compatibility for geth service name #2053

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

pablomendezroyo
Copy link
Contributor

@pablomendezroyo pablomendezroyo commented Nov 5, 2024

Geth package has changed its service name from geth.dnp.dappnode.eth to geth. This change will cause an issue when updating from production due to the compose settings not being persisted.

Fix:

  • return geth.dnp.dappnode.eth service name for version less than 0.1.43
  • return geth service name for version greater than 0.1.44

@pablomendezroyo pablomendezroyo requested a review from a team as a code owner November 5, 2024 09:33
@github-actions github-actions bot temporarily deployed to commit November 5, 2024 09:34 Inactive
Copy link

github-actions bot commented Nov 5, 2024

Copy link

github-actions bot commented Nov 5, 2024

Dappnode bot has built and pinned the built packages to an IPFS node, for commit: 09755b6

This is a development version and should only be installed for testing purposes.

  1. Package dappmanager.dnp.dappnode.eth

Install link

Hash: /ipfs/QmTtuQoHdf65eGo16ynw6zecmgjCEUepRwKNzngwxf7A9j

(by dappnodebot/build-action)

@github-actions github-actions bot temporarily deployed to commit November 5, 2024 13:43 Inactive
@pablomendezroyo pablomendezroyo merged commit 63d08cf into develop Nov 5, 2024
7 checks passed
@pablomendezroyo pablomendezroyo deleted the pablo/edge-case-geth branch November 5, 2024 15:32
@pablomendezroyo pablomendezroyo changed the title Contemplate edge case geth Implement bacwards compatibility for geth service name Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant