Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RocketMap PR Port] Show timers below Pokémon icons #29

Open
wants to merge 7 commits into
base: devbuild
Choose a base branch
from
Open

[RocketMap PR Port] Show timers below Pokémon icons #29

wants to merge 7 commits into from

Conversation

AboveColin
Copy link
Collaborator

@AboveColin AboveColin commented Mar 23, 2018 •
edited
Loading

Description

Show a timer below the Pokemon icon

How Has This Been Tested?

Tested on my own map.

Screenshots (if appropriate):

image

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@darkelement1987 darkelement1987 added the enhancement New feature or request label Mar 23, 2018
@darkelement1987 darkelement1987 added this to the Milestone milestone Mar 23, 2018
@darkelement1987
Copy link
Owner

Once i can test my map i will merge, i'm sure it works fine 👍

@darkelement1987
Copy link
Owner

Still has bugs. Timers flicker when hovering label or dragging the map around.

@darkelement1987 darkelement1987 changed the base branch from MIX_MEWTWO to devbuild March 24, 2018 01:29
@darkelement1987
Copy link
Owner

Changed base branch to devbuild

@darkelement1987 darkelement1987 added New Feature New feature and removed enhancement New feature or request labels Mar 30, 2018
@The-Real-Ketchum-Dev
Copy link

is this ready for merge?

@darkelement1987
Copy link
Owner

No, see comments.

@darkelement1987 darkelement1987 added help wanted Extra attention is needed RM-Port labels Apr 13, 2018
@darkelement1987 darkelement1987 changed the title Show timers below Pokémon icons [RocketMap PR Port] Show timers below Pokémon icons Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@The-Real-Ketchum-Dev The-Real-Ketchum-Dev The-Real-Ketchum-Dev approved these changes

@darkelement1987 darkelement1987 darkelement1987 approved these changes

Assignees
No one assigned
Labels
help wanted Extra attention is needed New Feature New feature RM-Port
Projects
None yet
Milestone
DarkFork 1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@AboveColin @darkelement1987 @The-Real-Ketchum-Dev