Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Support for Pentax PixelShift #11608

Closed
wants to merge 27 commits into from

Conversation

maruncz
Copy link
Contributor

@maruncz maruncz commented Apr 23, 2022

This PR adds support for multiframe raws into rawprepare, temperature and demosaic modules.
This enables demosaic module to merge them together.

This PR requres to merge this darktable-org/rawspeed#350

There is only basic pixelshift algorithm implemented, ultimate goal is closer to what rawtherapee is doing, but i think that will be in next PRs.

Because i have no prior experience with OpenCL or OpenMP, i only implemented basic CPU paths.

There are some leftover debug printfs, i'll remove them at the end.

@maruncz maruncz requested a review from LebedevRI as a code owner April 23, 2022 15:40
@maruncz
Copy link
Contributor Author

maruncz commented Apr 25, 2022

I would like to add more description.

First I had to modify rawspeed to support multiple frames, this unfortunately breaks API.

Then i had to modify dt_iop_buffer_dsc_t to account for multiple frames, all frames are merged togrther in one buffer.
This also meant i had to modify all places that allocate those buffers.

Pixelshift algorithm is implemented in demosaic. This meant that i had to modify rawprepare and temperature modules, because those are before demosaic in pixelpipe.
If there is another module that comes before demosaic, please let me now.

Before I attempt to do speed optimizations, please let me now, if this PR has any chance of merging.

@github-actions
Copy link

github-actions bot commented Jul 7, 2022

This pull request did not get any activity in the past 60 days and will be closed in 365 days if no update occurs. Please verify it has no conflicts with the master branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work.

@dterrahe dterrahe added the scope: camera support adding WB and raw support for new cameras label Apr 28, 2023
@github-actions
Copy link

This pull request has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please verify it has no conflicts with the master branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work.

Copy link

This pull reguest was closed because it has been inactive for 300 days since being marked as stale.

@github-actions github-actions bot closed this Apr 24, 2024
@kmilos kmilos mentioned this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-pr-activity scope: camera support adding WB and raw support for new cameras
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants