Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RL_out_sharp: copy EXIF, add variable output path (copy from rename_i… #385

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hqhoang
Copy link

@hqhoang hqhoang commented Mar 5, 2022

RL_out_sharp: support variable path (copy from rename_images.lua), copy EXIF to final file, work around GMIC problem with long filename by moving the exported file afterward.

Also update the end indentation and trim trailing spaces to match the other scripts's convention.

hqhoang added 2 commits March 5, 2022 16:03
…mages.lua),

work around GMIC long filename problem
…" to avoid large temp storage (especially for TIFF16)
@wpferguson
Copy link
Member

2 days ago I started looking at not waiting until the end to sharpen for postsharpen.lua. Let me see what I come up with and we'll compare the 2.

The variable substitution code needs to be moved to a library. This makes (at least) 3 scripts that are using it. I'll try and get that done tonight for tomorrow.

@hqhoang
Copy link
Author

hqhoang commented Mar 6, 2022

LOL, I was also about to request if you could move that variable substitution code into a library, many scripts definitely will benefit from that. Having the combo entry/button like the "file on disk" would be nice. No hurry, though. I got it to work for me at the moment.

It seems that the old code was able to modify img_format.bpp (forcing TIF 16bit) but that doesn't seem to work anymore. When I set the return empty table {} from initialize() to stop the export, it would crash darktable if I click on the export buttons repeatedly. Not sure if I should submit a bug report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants