-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panasonic DC-GH6 raws are version 8 - new decompressor needed #367
Comments
I uploaded a full set (all variants of crops) on raw.pixls.us with Creative Commons Zero (CC0) license at August, 22nd. Uwe |
Any progress on adding GH6 to Darktable? |
Unfortunately last version of darktable 4.2.0 didn't add support to GH6, same with GH5M2 though files are available for both cameras on raw.pixls.us. Only way to use darktable with those cameras is to convert RAW pictures to DNG |
Tracker for other models depending on v8 decoder: darktable-org/darktable#13511 |
It depends on someone reverse engineering the new codec and releasing the spec or code as open source, it doesn't necessarily have to come from LibRaw. |
Just landed for porting: https://github.com/LibRaw/LibRaw/blob/master/src/decoders/pana8.cpp @jdneumeyer77 @mlouielu |
That code is pretty ugly. Not sure when I'll get a chance to work on it, but hopefully over the next couple weeks I'll take crack at an initial port. |
:)
If you do want to take a look at this, i would strongly suggest the PR should be just the code being copied over, |
Unlike all other open source implementations of Panasonic RawFormat=8 decoders, this one works |
Appreciate your team's work, and generously open sourced it in a swiftly manner. Originally I thought it will be scheduled at the end of 2024. |
I never doubted it worked, since it's had time to incubate. I still appreciate the time and effort it took to reverse engineer and test it from your team. Thanks for releasing as open source. |
I've finished my Rust port of the pana8 decoder: dnglab/dnglab@03c3d5d, based on libraw code. |
Upvoting. I'd love to see Darktable support this V8 codec, used by the GH6, but also I believe the G9M2 (which I have and can test). And I suspect the new GH7.. And I see G9M2 samples present at https://raw.pixls.us/data/Panasonic/DC-G9M2/. Thank you! PS -is there some ETA/version of DT that will get this? |
Darktable already uses LibRaw to process Canon CR3 files. So, adding such a processing path for Panasonic/V8 should be easy. |
EDIT: I've learned this is the wrong issue/tracker for this comment. I've truncated it so it isn't as much of an eyesore. New Darktable user and Lumix G9II owner here. I've taken a pass at adding support via libraw, and things are looking pretty good so far. I'm not very familiar with the codebase, so I've mostly just been muddling through. I'd love feedback from experienced contributors on what else ought to be done before submitting a PR, and for some guidelines regarding the amount of testing and consistency expected for contributions. All I've done so far is add 'rw2' to the extension whitelist for libraw: and update the G9M2 entry in I may adopt some of the changes from here as well. Values for the black & white levels and color matrix are extracted from the EXIF on DNG's converted from my RW2 files, as documented by https://www.darktable.org/2012/10/whats-involved-with-adding-support-for-new-cameras/. This alone seems to have gotten me 95%+ of the way there. With these changes the RW2 files can be opened and edited. Opening both the RW2s and DNGs converted from them show them apparently matching with a just few caveats. EDIT: [Original comment continued with info regarding testing of RW2's via this libraw workaround] |
Thanks, but that's not the real fix being looked for here. P.S. The change to |
Oh, I see. Apologies for the confusion. I was scouring for info on RW2v8 support for DT, and ended up thinking this was the main issue tracking the topic. I see now this is the wrong repo. I'm still interested in pitching in if someone is willing to point me in the right direction. Seems like a lot of people are eagerly awaiting support for RW2v8. Is the stance that libraw's decoder not considered suitable for a release, thus requiring a full port/rewrite to rawspeed instead? Or does it make sense to push the libraw workaround further within the Darktable repo? |
Great. See the comment above.
IMHO it does not as it can readily be enabled from the user config file.
Edit 2: Take that back again! 😉 It does simply work, only just up to G9M2, but not for the S9 that is also not yet supported by the public LibRaw 202403 snapshot... |
No description provided.
The text was updated successfully, but these errors were encountered: