Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panasonic DC-G9M2 support (data only) #529

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kmilos
Copy link
Contributor

@kmilos kmilos commented Oct 11, 2023

Partly addresses darktable-org/darktable#15679

Used ADC 16.0. Crop is unverified.

This depends on #367

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0c1902a) 59.08% compared to head (6fa3fef) 59.08%.
Report is 874 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #529   +/-   ##
========================================
  Coverage    59.08%   59.08%           
========================================
  Files          232      232           
  Lines        13903    13903           
  Branches      1939     1939           
========================================
  Hits          8214     8214           
  Misses        5556     5556           
  Partials       133      133           
Flag Coverage Δ
benchmarks 8.17% <ø> (ø)
integration 47.49% <ø> (ø)
linux 57.00% <ø> (ø)
macOS 18.67% <ø> (ø)
rpu_u 47.49% <ø> (ø)
unittests 18.22% <ø> (ø)
windows ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LebedevRI
Copy link
Member

@kmilos hmm you know what we could do?

Since we are polluting cameras.xml with garbage anyways,
why don't we add "dormant" entries for cameras that exist in the wild,
(of which we are ignorant of), e.g. for the purposes of RPU sample asking
(RPU does that automatically more or less).

We will need supported="unknown" though, so rawspeed does not
start considered them supported since it's present in cameras.xml.

Does that sound interesting to you?

@kmilos
Copy link
Contributor Author

kmilos commented Dec 25, 2023

Sorry Roman, I might be slow these days - how is this exactly different/what's the benefit compared to what we have today: error and ask for samples if camera is not supported, or mode='no-samples'?

@LebedevRI
Copy link
Member

mode='no-samples' means "this camera was supposedly explicitly supported, but we don't really know".
Note the word "explicitly". Currently we can't add a camera to cameras.xml without
deeming it either supported or unsupported.

supported="unknown-no-samples" would allow us to list (in cameras.xml) more known
(to exist in the real world) cameras, without deeming them either supported or unsupported.
That could be helpful e.g. for RPU sample request lists.

This, of course, hinges on the access to such list of real-world cameras.

@kmilos
Copy link
Contributor Author

kmilos commented Jan 3, 2024

This, of course, hinges on the access to such list of real-world cameras.

So far, I've just been using https://www.dpreview.com/products/timeline?year=all&brand=&category=cameras for manually checking some coverage and to keep on top of new cameras...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Requires New Raw Format Support
Development

Successfully merging this pull request may close these issues.

2 participants