Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing schema ImBack camera maker #517

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

kmilos
Copy link
Contributor

@kmilos kmilos commented Sep 6, 2023

Cf. recent commit 59cf9f9

Should it be "ImBack" or "Imback"? We left GoPro, OnePlus, etc. alone AFAICT?

@LebedevRI
Copy link
Member

I'm reasonably sure i just used what was in the DNG provided by the linked tool.
To be fully honest, i do not particularly understand this name normalization/sanitization,
it's rules really need to be documented.

@LebedevRI LebedevRI merged commit 750e2b4 into darktable-org:develop Sep 6, 2023
43 of 45 checks passed
@LebedevRI
Copy link
Member

Thank you!

@kmilos
Copy link
Contributor Author

kmilos commented Sep 6, 2023

To be fully honest, i do not particularly understand this name normalization/sanitization,
it's rules really need to be documented.

Yeah, I think the dngmeta.sh script does a blind sentence capitalization for the rawspeed internal ID maker attribute (this was to handle and prettify NIKON, RICOH, SONY, etc.), so there is still a need to double-check this manually...

@kmilos kmilos deleted the patch-1 branch September 6, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants