Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fujifilm GFX100 II support #530

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

kmilos
Copy link
Contributor

@kmilos kmilos commented Oct 12, 2023

Using ADC 16.0

Currently uncompressed and lossless compressed only, as with other Fujifilm cameras.

darktable-org/darktable#16130

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d662550) 59.26% compared to head (0365ff1) 59.26%.
Report is 86 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #530   +/-   ##
========================================
  Coverage    59.26%   59.26%           
========================================
  Files          251      251           
  Lines        14849    14849           
  Branches      2000     2000           
========================================
  Hits          8801     8801           
  Misses        5931     5931           
  Partials       117      117           
Flag Coverage Δ
benchmarks 10.59% <ø> (ø)
integration 46.66% <ø> (ø)
linux 56.90% <ø> (ø)
macOS 20.86% <ø> (ø)
rpu_u 46.66% <ø> (ø)
unittests 18.47% <ø> (ø)
windows ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmilos
Copy link
Contributor Author

kmilos commented Oct 13, 2023

@LebedevRI I have a few open PRs where codecov seems to be running periodically and updating the status, you have any idea what might be triggering it?

@LebedevRI
Copy link
Member

@LebedevRI I have a few open PRs where codecov seems to be running periodically and updating the status, you have any idea what might be triggering it?

I don't have an answer but i could guess that it either reacted to the new changes in the develop branch,
or some github CI job completed/timeouted and it updated the status accordingly. Does not seem erroneous to me.

@kmilos
Copy link
Contributor Author

kmilos commented Jan 17, 2024

Updated the crop slightly, should be good to go now - seems to be working ok on those RPU samples (except the lossy ones of course).

P.S. I think you can remove the 32-bit MSYS environments from CI, they're being phased out.

@LebedevRI
Copy link
Member

P.S. I think you can remove the 32-bit MSYS environments from CI, they're being phased out.

Right. At this point i'm not really sure if this library needs to support 32-bit environment
(in general, not just for some specific OS), so while i've tried to keep 32-bit CI working
(openSUSE_Tumbleweed @ i586 is essentially dead too),
i'm not sure how much effort is worth spending on that.

But once said CI can not be used anymore, 32-bit env would also be blocked via a cmake check like compiler versions.

@LebedevRI
Copy link
Member

I can not verify crop at all here, samples are really bad.

@LebedevRI LebedevRI merged commit 45d01da into darktable-org:develop Jan 25, 2024
54 of 55 checks passed
@LebedevRI
Copy link
Member

@kmilos thank you!

@kmilos kmilos deleted the kmilos/fuji_gfx100ii branch January 25, 2024 21:48
@kmilos
Copy link
Contributor Author

kmilos commented Jan 25, 2024

Pretty sure it's meant to be the same as Mark I...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Resolved
Development

Successfully merging this pull request may close these issues.

2 participants