Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(renovate): update to eslint v9 and fix lint errors/warnings #219

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(renovate): update to eslint v9 and fix lint errors/warnings #219

wants to merge 1 commit into from

Conversation

felixvictor
Copy link

  • yarn.lock removed
  • typescript downgraded to 5.5.4 as typescript-eslint cannot parse 5.6 version
  • test for suite "injectable-should-be-provided" still fails

@ChrisMBarr
Copy link
Contributor

Can this be looked at again? I am attempting to update to ESLint v9 and I find this plugin very helpful but it looks like I'll have to remove this plugin so I can upgrade

@lluiscab
Copy link

What's the reasoning for removing yarn and replacing it with npm? It's quite a major change that has nothing to do with eslint v9 and it's just adding a ton of bloat to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darraghoriordan darraghoriordan Awaiting requested review from darraghoriordan darraghoriordan is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixvictor @ChrisMBarr @lluiscab