Dart Debug Extension: don't forward events to Chrome that will cause a crash #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…will cause the page to crash
annagrin
approved these changes
Aug 3, 2023
| final chromeVersionMatch = | ||
| RegExp('Chrome/([0-9.]+)').firstMatch(window.navigator.userAgent); | ||
| final chromeVersion = | ||
| chromeVersionMatch == null ? '' : chromeVersionMatch[0]; |
There was a problem hiding this comment.
Nit: can this be chromeVersion = chromeVersionMatch?[0] ?
| RegExp('Chrome/([0-9.]+)').firstMatch(window.navigator.userAgent); | ||
| final chromeVersion = | ||
| chromeVersionMatch == null ? '' : chromeVersionMatch[0]; | ||
| if (chromeVersion?.startsWith('Chrome/115') ?? false) { |
There was a problem hiding this comment.
Nit: can this be
return chromeVersion?.startsWith('Chrome/115') ?? false;or maybe
if (chromeVersion != null && chromeVersion.startsWith('Chrome/115')) {
return true;
}?
|
auto label is removed for dart-lang/webdev, pr: 2179, due to - The status or check suite unit_test; windows; Dart main; PKG: dwds; `dart test --total-shards 3 --shard-index 1 --exclude-t... has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See details in https://bugs.chromium.org/p/chromium/issues/detail?id=1469092
This PR skips forwarding events that will cause a crash to Chrome, and instead displays a warning to the user:
FYI @DanTup