feat: upgrade to ZMQ 6.0 using dashd-zmq client #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Werner
force-pushed
the
feat/zmq-6
branch
from
26790fc to
88d1bf9
Compare
Cofresi
suggested changes
Dec 9, 2020
Cofresi
suggested changes
Dec 9, 2020
Cofresi
reviewed
Dec 9, 2020
|
Good news: zeromq.js 6 might be better than zeromq.js 5 (which is in various states of buggy and broken) Bad news: 3 years later and zeromq.js 6 is left incomplete. 🤷♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
As we have a implementation for 6.0 in js-dashd-zmq available which shares practically the same API that the one we currently have, and because 6.0 is meant to fix some fundamentals issues and that as highlighted by #69 we do have some issue with ZMQ.
We decided to start the discussion around a migration towards it.
What was done?
How Has This Been Tested?
Breaking Changes
Checklist: