Compatibility with latest dask, pyarrow and deltalake #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll have a look and see what bothers CI |
fjetter
reviewed
Feb 13, 2024
| import dask.dataframe as dd | ||
| import pyarrow as pa | ||
| import pyarrow.parquet as pq | ||
| from dask.base import tokenize | ||
| from dask.dataframe.io.parquet.arrow import ArrowDatasetEngine |
There was a problem hiding this comment.
This import is a bit ugly but this class exposes our type mappers and this way we can align behavior
fjetter
changed the title
fjetter
changed the title
fjetter
reviewed
Feb 13, 2024
Comment on lines
+223
to
224
| graph = HighLevelGraph.from_collections(final_name, dsk, dependencies=(written,)) # type: ignore | ||
| result = Scalar(graph, final_name, "") |
There was a problem hiding this comment.
I'll migrate to dask-expr in a follow up PR once this is green
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
==========================================
+ Coverage 73.37% 74.06% +0.68%
==========================================
Files 6 6
Lines 308 320 +12
==========================================
+ Hits 226 237 +11
- Misses 82 83 +1 ☔ View full report in Codecov by Sentry. |
|
CI is green. @fjetter can I leave this PR with you? |
|
Thanks Florian
…On Tue, Feb 13, 2024 at 7:49 AM Florian Jetter ***@***.***> wrote:
Merged #68 <#68> into
main.
—
Reply to this email directly, view it on GitHub
<#68 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACKZTFMIKAWTZLOBDVSPWDYTNVNJAVCNFSM6AAAAABDFOUMPCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRG44DSMBSGM3TSNY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65
cc @fjetter there is probably a better way to do this in case you all want to improve things here and make them more future-proof.