Skip to content

Commit

Permalink
Skip sasl installation
Browse files Browse the repository at this point in the history
  • Loading branch information
charlesbluca committed Jan 8, 2024
1 parent 3e58de2 commit e96115a
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 7 deletions.
1 change: 0 additions & 1 deletion .github/workflows/test-upstream.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ jobs:
- name: Install hive testing dependencies
if: matrix.os == 'ubuntu-latest'
run: |
mamba install -c conda-forge "sasl>=0.3.1"
docker pull bde2020/hive:2.3.2-postgresql-metastore
docker pull bde2020/hive-metastore-postgresql:2.3.0
- name: Install upstream dev Dask
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,9 @@ jobs:
run: |
maturin develop
- name: Install hive testing dependencies
# FIXME: sasl is not available on python 3.11
if: |
matrix.os == 'ubuntu-latest'
&& matrix.python != '3.11'
run: |
mamba install -c conda-forge "sasl>=0.3.1"
docker pull bde2020/hive:2.3.2-postgresql-metastore
docker pull bde2020/hive-metastore-postgresql:2.3.0
- name: Optionally install upstream dev Dask
Expand Down
5 changes: 2 additions & 3 deletions tests/integration/test_hive.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,8 @@
from tests.utils import assert_eq

pytestmark = pytest.mark.xfail(
# FIXME: sasl is not available on python 3.11
condition="sys.platform in ('win32', 'darwin') or sys.version_info == (3, 11)",
reason="hive testing only supported on linux with python<3.11",
condition="sys.platform in ('win32', 'darwin')",
reason="hive testing not supported on Windows/macOS",
)
docker = pytest.importorskip("docker")
sqlalchemy = pytest.importorskip("sqlalchemy")
Expand Down

0 comments on commit e96115a

Please sign in to comment.