Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

affine_transform: increased shape of required input array slices #216

Merged
merged 1 commit into from
May 14, 2021

Conversation

m-albert
Copy link
Collaborator

@m-albert m-albert commented May 7, 2021

This PR fixes a problem revealed by the tests of @martinschorb when using affine_transform within rotate in this PR #213.

Some choices of transformation parameters, which hadn't been covered in the tests so far, require a larger input array slice to compute the output chunks.

Only code change in this PR: +2 instead of +1:

        rel_image_slice = tuple([slice(int(rel_image_i[dim]),
                                       int(rel_image_f[dim]) + 2)
                                 for dim in range(n)])

I modified the tests to reflect the requirement for these larger input slices.

@m-albert m-albert mentioned this pull request May 7, 2021
@GenevieveBuckley GenevieveBuckley merged commit b931f7e into dask:main May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants