Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relaxed type check of input array, to allow da.core.Array sub-classes… #361

Merged

Conversation

sommerc
Copy link
Contributor

@sommerc sommerc commented Apr 22, 2024

For some file formats aicsimageio and nd2 return a sub-class of da.core.Array: ResourceBackedDaskAray

This PR relaxes the input type check to allow da.core.Array sub-classes in ndinterp functions.

Closes #360

@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

@m-albert
Copy link
Collaborator

add to allowlist

@m-albert
Copy link
Collaborator

Thanks for the PR @sommerc 🙏

There's an error showing up in the tests that's unrelated to this PR, so we'll need to get the associated issue #362 fixed to turn the tests green here.

@sommerc
Copy link
Contributor Author

sommerc commented Apr 23, 2024

Thanks you @m-albert! Let me know if I can do sth.

btw. I noticed problems using current pytest >= 8.0. And had to pin pytest < 8.0. In the current version of pytest the signature of pytest.skip() has changed

@GenevieveBuckley
Copy link
Collaborator

btw. I noticed problems using current pytest >= 8.0. And had to pin pytest < 8.0. In the current version of pytest the signature of pytest.skip() has changed

fyi I've fixed this particular problem in the main branch now 😄

@GenevieveBuckley GenevieveBuckley merged commit bb11938 into dask:main May 14, 2024
14 of 15 checks passed
@GenevieveBuckley
Copy link
Collaborator

This is a very useful change to have, thank you for contributing @sommerc 🎉

@sommerc
Copy link
Contributor Author

sommerc commented May 14, 2024

Very small, but indeed usefull when data come from aicsimageio :-)

Thank you guys for your time and efforts in providing such a great resource!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ndinterp methods fails with ResourceBackedDaskArray from aicsimageio
4 participants