Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI test environments #367

Merged
merged 6 commits into from
May 14, 2024

Conversation

GenevieveBuckley
Copy link
Collaborator

@GenevieveBuckley GenevieveBuckley commented May 14, 2024

This PR:

I didn't think we needed to do this, since all of the CI checks for #363 passed before we merged it, but manually triggering CI on the main branch is failing (see here). So this is an attempt to fix that problem.

@GenevieveBuckley GenevieveBuckley marked this pull request as draft May 14, 2024 07:08
@GenevieveBuckley
Copy link
Collaborator Author

We need to wait for the CI checks to finish running, and see if they all successfully create conda environments. Then we can commit this suggestion, and merge the PR.

Note: we are still expecting to see pytest failures here, which will be fixed by #366. But if pytest runs at all, then the conda environment definitely was created properly.

@GenevieveBuckley GenevieveBuckley marked this pull request as ready for review May 14, 2024 07:36
@GenevieveBuckley GenevieveBuckley merged commit 23d3804 into dask:main May 14, 2024
0 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants