Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List dependencies correctly in distributions. #109

Merged
merged 1 commit into from
Sep 25, 2023
Merged

List dependencies correctly in distributions. #109

merged 1 commit into from
Sep 25, 2023

Commits on Sep 25, 2023

  1. List dependencies correctly in distributions. 

    I noticed that when installing `dask-mpi` by itself, it does not come
with any dependencies, contrary to what `setup.py` hints at.

On a barebones cluster, I got this trying to set up a small reproducer:
```
-bash-4.2$ python3 -mvenv foobar; . ./foobar/bin/activate; pip install dask-mpi
Collecting dask-mpi
  Using cached dask_mpi-2022.4.0-py3-none-any.whl (11 kB)
Installing collected packages: dask-mpi
Successfully installed dask-mpi-2022.4.0
(foobar) -bash-4.2$ pip list
Package    Version
---------- --------
dask-mpi   2022.4.0
pip        22.0.4
setuptools 47.1.0
```

It seems that the code that actually specifies the dependencies has been
commented out for a while. This PR reactivates it.

Tested with `python -mbuild -n` (no build isolation due to the YAML
dependency for `setup.py`) and looking at the `METADATA` file of the
resulting wheel.
    @matz-e
    matz-e committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    2ae8027 View commit details
    Browse the repository at this point in the history