Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Test upstream CI build #8875

Closed
wants to merge 5 commits into from

Conversation

jrbourbeau
Copy link
Member

Checking to see if our upstream build is passing (xref #8776 (comment))

@jrbourbeau
Copy link
Member Author

Looks like we're still installing the same nightly version as yesterday. Actually, if I look back a few days, installing from https://pypi.anaconda.org/scipy-wheels-nightly/simple is giving the same pandas nightly package version. @jorisvandenbossche do you know if there are any known issues around pandas nightly versions not being updated?

@jorisvandenbossche
Copy link
Member

https://pypi.anaconda.org/scipy-wheels-nightly/simple/pandas/ indicates that there are more recent pandas versions, but so not directly an idea why pip is only finding an older one (pandas-1.5.0.dev0+506.g17dda440f9).

Locally, I get the same (in a clean env):

$     python -m pip install --no-deps --pre \
>         -i https://pypi.anaconda.org/scipy-wheels-nightly/simple \
>         numpy \
>         pandas
Looking in indexes: https://pypi.anaconda.org/scipy-wheels-nightly/simple
Collecting numpy
  Downloading https://pypi.anaconda.org/scipy-wheels-nightly/simple/numpy/1.23.0.dev0%2B967.g41cf10dcb/numpy-1.23.0.dev0%2B967.g41cf10dcb-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (17.0 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 17.0/17.0 MB 90.3 kB/s eta 0:00:00
Collecting pandas
  Downloading https://pypi.anaconda.org/scipy-wheels-nightly/simple/pandas/1.5.0.dev0%2B506.g17dda440f9/pandas-1.5.0.dev0%2B506.g17dda440f9-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (11.9 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 11.9/11.9 MB 53.3 kB/s eta 0:00:00
Installing collected packages: pandas, numpy
Successfully installed numpy-1.23.0.dev0+967.g41cf10dcb pandas-1.5.0.dev0+506.g17dda440f9

@jorisvandenbossche
Copy link
Member

cc @simonjayhawkins

@simonjayhawkins
Copy link

Thanks @jorisvandenbossche. the nightly builds from main have been failing for a while. didn't realize this till prepped for the release pandas-dev/pandas#45961 (comment) cc @lithomas1

@simonjayhawkins
Copy link

simonjayhawkins commented Apr 4, 2022

it looks like it maybe quite simple to fix... the failing test (preventing the wheels from being upload) is not being skipped by is_ci_environment added in pandas-dev/pandas#45812. looks like we need to set an environment variable for MacPython.

@simonjayhawkins
Copy link

Looks like we're still installing the same nightly version as yesterday. Actually, if I look back a few days, installing from https://pypi.anaconda.org/scipy-wheels-nightly/simple is giving the same pandas nightly package version. @jorisvandenbossche do you know if there are any known issues around pandas nightly versions not being updated?

should be ok now.

@jsignell
Copy link
Member

jsignell commented Apr 7, 2022

It looks like I forgot to actually merge #8558 - so it's that and some new groupby failures

@jrbourbeau
Copy link
Member Author

should be ok now.

Awesome, thanks for the update @simonjayhawkins! Indeed I'm no longer seeing the segfault 🎉

It looks like I forgot to actually merge #8558 - so it's that and some new groupby failures

Rerunning now that #8558 has been merged

@ian-r-rose
Copy link
Collaborator

Looks like a lot of the failures are due to pandas-dev/pandas#34998, merged a few days ago

@jsignell
Copy link
Member

Looks like a lot of the failures are due to pandas-dev/pandas#34998, merged a few days ago

Oh that is a very nice change! It seems like it will make groupby much more predictable going forward. I can open a PR to address the changes that we need in dask. Unless someone is already on it?

@jrbourbeau
Copy link
Member Author

I'm not aware of anyone working it : )

@jcrist
Copy link
Member

jcrist commented May 5, 2022

Is there more you wanted to poke at here, or can this be closed?

@jrbourbeau jrbourbeau closed this May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants