Block fusion for barrier tasks #8944
Conversation
distributed/shuffle/_core.py
Outdated
| @@ -584,6 +584,7 @@ def p2p_barrier(id: ShuffleId, *run_ids: int) -> int: | |||
|
|
|||
| class P2PBarrierTask(Task): | |||
| spec: ShuffleSpec | |||
| block_fusion: bool | |||
There was a problem hiding this comment.
This would require hasattr in the fusion code, wouldn't it? I like the idea with the property on the baseclass better
There was a problem hiding this comment.
No, I defined it over in dask/dask on every class (but that's ugly in a different way)...
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 25 files ±0 25 suites ±0 10h 18m 5s ⏱️ + 5m 28s For more details on these failures, see this check. Results for commit 0f2f156. ± Comparison against base commit 750cb91. ♻️ This comment has been updated with latest results. |
|
Yeah agree with the property, migrated both PRs |
Closes #xxxx
pre-commit run --all-files