feat(DMVP-5664): fix flagger-metric-template chart default options, h…

…ave readme and do cleanup
dasmeta · Nov 6, 2024 · 0877f1a · 0877f1a
1 parent e46dad5
commit 0877f1a
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 5 deletions.
diff --git a/charts/flagger-metric-template/README.md b/charts/flagger-metric-template/README.md
@@ -0,0 +1,12 @@
+# This helm chart allows to create flagger custom metric templates to use in canary rollout
+
+## There is option named `createNginxCustomMetricTemplates`(which is true by default) to create nginx custom metrics named `request-success-rate-custom` and `request-duration-custom` 
+
+## example of custom metric templates
+```yaml
+metricTemplates:
+  - name: my-custom-request-rate-metric-template
+    query: |
+      sum(rate(nginx_ingress_controller_requests{exported_namespace="{{ namespace }}",ingress="{{ ingress }}",status!~"5.*"}[1m]))/sum(rate(nginx_ingress_controller_requests{exported_namespace="{{ namespace }}",ingress="{{ ingress }}"}[1m]))*100
+
+```
diff --git a/charts/flagger-metric-template/files/nginx-request-success-rate-custom b/charts/flagger-metric-template/files/nginx-request-success-rate-custom
diff --git a/charts/flagger-metric-template/values.yaml b/charts/flagger-metric-template/values.yaml
@@ -11,9 +11,9 @@ provider:
 createNginxCustomMetricTemplates: true
 
 # List of custom metric template configs
-# metricTemplates: []
+metricTemplates: []
 ## example for metric templates
-metricTemplates:
-  - name: my-custom-request-rate-metric-template
-    query: |
-      sum(rate(nginx_ingress_controller_requests{exported_namespace="{{ namespace }}",ingress="{{ ingress }}",status!~"5.*"}[1m]))/sum(rate(nginx_ingress_controller_requests{exported_namespace="{{ namespace }}",ingress="{{ ingress }}"}[1m]))*100
+# metricTemplates:
+#   - name: my-custom-request-rate-metric-template
+#     query: |
+#       sum(rate(nginx_ingress_controller_requests{exported_namespace="{{ namespace }}",ingress="{{ ingress }}",status!~"5.*"}[1m]))/sum(rate(nginx_ingress_controller_requests{exported_namespace="{{ namespace }}",ingress="{{ ingress }}"}[1m]))*100