Merge pull request #119 from dasmeta/DMVP-5857

fix(DMVP-5857): Fix data dump in configmap for version 0.1.18
dasmeta · Oct 28, 2024 · 7fc33f9 · 7fc33f9
2 parents b8748f1 + 631a602
commit 7fc33f9
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/charts/base-cronjob/Chart.yaml b/charts/base-cronjob/Chart.yaml
@@ -15,11 +15,11 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.1.18
+version: 0.1.19
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to
 # follow Semantic Versioning. They should reflect the version the application is using.
 # It is recommended to use it with quotes.
 
-appVersion: "0.1.18"
+appVersion: "0.1.19"
diff --git a/charts/base-cronjob/README.md b/charts/base-cronjob/README.md
@@ -41,6 +41,8 @@ For example, set this to escape from creating an empty ConfigMap resource:
 ```
 config:
   enabled: false
+  data: 
+    <data>
 ```
 Specify this to create ServiceAccount resource:
 ```

diff --git a/charts/base-cronjob/templates/configmap.yaml b/charts/base-cronjob/templates/configmap.yaml
@@ -6,6 +6,6 @@ apiVersion: v1
 metadata:
   name: {{ $job.name | quote}}
 data:
-  {{- toYaml $job.config | nindent 2 }}
+  {{- toYaml $job.config.data | nindent 2 }}
 {{- end }}
 {{- end }}
-Original file line number
+Diff line change
@@ Expand Up @@
     ```
     config:
       enabled: false
+      data:
+        <data>
     ```
     Specify this to create ServiceAccount resource:
     ```
@@ Expand Down @@