Skip to content

Commit

Permalink
fix(DMVP-5971): Update chart for support annotation and terminationgr…
Browse files Browse the repository at this point in the history
…aceperiod
  • Loading branch information
aramkarapetian committed Nov 6, 2024
1 parent ed8bc6a commit 91a0eb3
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 2 deletions.
4 changes: 2 additions & 2 deletions charts/base/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.2.5
version: 0.2.6

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
# It is recommended to use it with quotes.
appVersion: "0.2.5"
appVersion: "0.2.6"
8 changes: 8 additions & 0 deletions charts/base/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -594,3 +594,11 @@ initContainers:
args:
- |
/test.sh


### Deployment use terminationGracePeriodSeconds parameter
terminationGracePeriodSeconds: 65

### Deployment use chart-hooks
annotations:
"helm.sh/hook": pre-install,pre-upgrade
7 changes: 7 additions & 0 deletions charts/base/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ metadata:
{{ $value.name }}: {{ $value.value | quote}}
{{- end }}
{{- end }}
{{- if .Values.annotations }}
annotations:
{{- toYaml .Values.annotations | nindent 4 }}
{{- end }}
spec:
{{- if .Values.minReadySeconds}}
minReadySeconds: {{ .Values.minReadySeconds }}
Expand Down Expand Up @@ -46,6 +50,9 @@ spec:
{{- end }}
{{- end }}
spec:
{{- if .Values.terminationGracePeriodSeconds }}
terminationGracePeriodSeconds: {{ .Values.terminationGracePeriodSeconds | default 30 }}
{{- end }}
{{- with .Values.imagePullSecrets }}
imagePullSecrets:
{{- toYaml . | nindent 8 }}
Expand Down

0 comments on commit 91a0eb3

Please sign in to comment.