Merge pull request #128 from dasmeta/DMVP-5592-variable-api-version

DMVP-5592: allow to set external-secret store operator apiVersion
dasmeta · Nov 29, 2024 · f4d3c5e · f4d3c5e
2 parents 81abb5f + c456ce5
commit f4d3c5e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/charts/base/Chart.yaml b/charts/base/Chart.yaml
@@ -15,10 +15,10 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.2.9
+version: 0.2.10
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to
 # follow Semantic Versioning. They should reflect the version the application is using.
 # It is recommended to use it with quotes.
-appVersion: "0.2.9"
+appVersion: "0.2.10"
diff --git a/charts/base/templates/external-secrets.yaml b/charts/base/templates/external-secrets.yaml
@@ -1,6 +1,6 @@
 {{- if and (eq .Values.secretsDefaultEngine "ExternalSecrets") .Values.secrets -}}
 {{ $fullName := include "base.fullname" .}}
-apiVersion: external-secrets.io/v1alpha1
+apiVersion: {{ .Values.externalSecretsApiVersion }}
 kind: ExternalSecret
 metadata:
   name: {{ $fullName }}

diff --git a/charts/base/values.yaml b/charts/base/values.yaml
@@ -124,6 +124,7 @@ ingress:
 
 secrets: []
 secretsDefaultEngine: "ExternalSecrets"
+externalSecretsApiVersion: external-secrets.io/v1alpha1 # TODO: the new version external-secrets.io/v1beta1 is available in external-secret operator, please update to new version as soon as you upgrade operator(the new dasmeta eks module already uses the new one)
 # secrets:
 #   - external-secret-1
 #   - external-secret-2