Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DMVP-5908): fix kms key alias #7

Merged
merged 4 commits into from
Dec 17, 2024
Merged

fix(DMVP-5908): fix kms key alias #7

merged 4 commits into from
Dec 17, 2024

Conversation

sophie-dasmeta-com
Copy link
Collaborator

No description provided.

Copy link

Output

monitoring.tf Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
Copy link

Output

main.tf Outdated
@@ -8,7 +8,7 @@ resource "aws_kms_key" "backup" {
}

resource "aws_kms_alias" "backup" {
name = "alias/aws_backup-${var.vault_name}"
name = var.kms_key_alias == null ? var.kms_key_alias : "alias/aws_backup-${var.vault_name}-${var.env}"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you need the following reverse check here, to use your custom passed kms key name when it is not null?

name = var.kms_key_alias != null ? var.kms_key_alias : "alias/aws_backup-${var.vault_name}-${var.env}"

monitoring.tf Show resolved Hide resolved
Copy link

Output

@sophie-dasmeta-com sophie-dasmeta-com merged commit 63564cd into main Dec 17, 2024
10 of 11 checks passed
Copy link

Output

Copy link

🎉 This PR is included in version 1.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants