Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DMVP-5330): have option named 'cloudwatch_outputs_enabled' in fluent_bit_config variable to control whether default cloudwatch log outputs/exports are enabled, it is enabled by default #104

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

mrdntgrn
Copy link
Contributor

No description provided.

…uent_bit_config variable to controll whether default cloudwatch log outputs/exports are enabled, it is enabled by default
Copy link

what-the-diff bot commented Sep 18, 2024

PR Summary

  • Introduction of a New Config Option
    The fluent_bit_configs has been updated to contain a new feature named cloudwatch_outputs_enabled. This allows users to control whether the default CloudWatch output is enabled or not, providing greater customization and control.

  • Module Changes
    The fluent-bit.tf module has been adjusted to set cloudwatch_outputs_enabled to true by default. This means that, initially, CloudWatch output will always be turned on until the user decides to change it.

  • Documentation Updates
    The README.md file for the modules/fluent-bit has been updated to reflect the newly updated structure of fluent_bit_config. This maintains the accuracy and usefulness of our documentation.

  • Test Adjustments
    Any redundant assertions from the tests existing in the modules/fluent-bit/tests directory have been removed to increase the efficiency and performance of these tests.

  • New Tests
    Additional tests have been included in order to cover scenarios in which the CloudWatch exporter can be disabled. This ensures robust testing strategy with the introduction of new configuration options.

  • Updated Templating Logic
    The values.yaml.tpl has been adjusted to decide whether to include CloudWatch output based on the value of cloudwatch_outputs_enabled. This adds an additional layer of robustness to the configuration management.

  • Changed AWS Provider Version in Tests
    The version for AWS provider in basic tests has been updated to 4.67.0, keeping our testing environment aligned with the most current stable version.

Copy link

Output

[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
[INFO] Initializing environment for https://github.com/qoomon/git-conventional-commits.
[INFO] Initializing environment for https://github.com/zricethezav/gitleaks.
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/zricethezav/gitleaks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check yaml...............................................................Passed
check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
- hook id: terraform_docs
- files were modified by this hook
Detect hardcoded secrets.................................................Passed

Copy link

Output

check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check yaml...............................................................Passed
check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
- hook id: terraform_docs
- files were modified by this hook
Detect hardcoded secrets.................................................Passed

Copy link

Output

check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check yaml...............................................................Passed
check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
- hook id: terraform_docs
- files were modified by this hook
Detect hardcoded secrets.................................................Passed

@mrdntgrn mrdntgrn merged commit c1dc507 into main Sep 19, 2024
35 checks passed
@mrdntgrn mrdntgrn deleted the DMVP-5330-option-to-disable-fluent-main-output branch September 19, 2024 08:23
Copy link

🎉 This PR is included in version 2.16.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

Output

[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
[INFO] Initializing environment for https://github.com/qoomon/git-conventional-commits.
[INFO] Initializing environment for https://github.com/zricethezav/gitleaks.
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/zricethezav/gitleaks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check yaml...............................................................Passed
check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
- hook id: terraform_docs
- files were modified by this hook
Detect hardcoded secrets.................................................Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants