Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMVP-2704: rework metrics #88

Merged
merged 3 commits into from
Nov 15, 2023
Merged

DMVP-2704: rework metrics #88

merged 3 commits into from
Nov 15, 2023

Conversation

aramkarapetian
Copy link
Contributor

Removed couple of unnecessary metrics and duplicate data from different dimentions.

Copy link

Output

check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check yaml...............................................................Passed
check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
- hook id: terraform_docs
- files were modified by this hook
Detect hardcoded secrets.................................................Passed

Copy link

what-the-diff bot commented Nov 15, 2023

PR Summary

  • Updated AWS Provider Version
    The version of the AWS provider was updated in the examples/spot-instance/README.md.

  • Metrics Edits in Local Variables
    Several metrics in the default_metrics and default_metrics_namespace_specific local variables were added, removed, and modified in modules/adot/locals.tf.

  • Helm Release Values Block Updated
    The values block in the helm_release resource was updated in modules/adot/main.tf.

  • Modified Relabel Configs
    Changes were made to the relabel_configs block in the prometheus.yml file located in modules/adot/templates/adot-values.yaml.tpl.

  • New Setup File in Module
    A new setup file (modules/adot/tests/basic/0-setup.tf) was added to the module, introducing additional configuration details.

  • Variables Updated in Basic Example
    The cluster_name and oidc_provider_arn variables were updated in modules/adot/tests/basic/1-example.tf.

  • Increased Required Terraform version
    The required_version in the terraform block was updated for modules/adot/tests/prometheus_metrics/0-setup.tf and tests/eks-fluent-bit/0-setup.tf, indicating a need for a newer version of the software.

  • Variables Updated in Prometheus Metrics Example
    The cluster_name and oidc_provider_arn variables were updated in modules/adot/tests/prometheus_metrics/1-example.tf.

  • New Files and a Module Added in EKS with ADOT Tests
    A new file was introduced in tests/eks-with-adot/0-setup.tf, a new module was added in tests/eks-with-adot/1-example.tf, and a new readme file was added in tests/eks-with-adot/README.md, expanding on the example capabilities and instructions for this specific test.

aghamyan44
aghamyan44 previously approved these changes Nov 15, 2023
Copy link

Output

check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check yaml...............................................................Passed
check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
- hook id: terraform_docs
- files were modified by this hook
Detect hardcoded secrets.................................................Passed

@aramkarapetian aramkarapetian merged commit 9f2bd40 into main Nov 15, 2023
35 checks passed
@aramkarapetian aramkarapetian deleted the DMVP-2704-rework-metrics branch November 15, 2023 11:55
Copy link

🎉 This PR is included in version 2.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

Output

check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check yaml...............................................................Passed
check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
- hook id: terraform_docs
- files were modified by this hook
Detect hardcoded secrets.................................................Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants