Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DMVP-3125): ADOT logging #93

Merged
merged 3 commits into from
Dec 15, 2023
Merged

fix(DMVP-3125): ADOT logging #93

merged 3 commits into from
Dec 15, 2023

Conversation

aghamyan44
Copy link
Contributor

No description provided.

Copy link

what-the-diff bot commented Dec 15, 2023

PR Summary

  • Update in Configuration Description

    • The description of the configuration option adot_config in README.md, modules/adot/README.md, modules/adot/variables.tf, and variables.tf have been updated. The new details clarify that accept_namespace_regex specifies the list of namespaces for exporting metrics, and additional_metrics defines any extra metrics that need to be exported.
  • Logging in ADOT Module

    • A new variable named logging has been added to the modules/adot/main.tf file. This variable helps in conditionally generating a logging block based on whether logging is enabled or not, as defined by the var.adot_config.logging_enable value. This update replaces previous attributes log_group_name and log_retention in the helm_release.adot-collector resource.
  • Dynamic Logging Attributes

    • In the modules/adot/templates/adot-values.yaml.tpl file, the previous static attributes log_group_name, log_stream_name, and log_retention under the awsemf/prometheus exporter and awsemf namespace have been made dynamic. Now, their values are generated based on the logging variable.
  • Addition of Logging Tests

    • New test files have been added to ensure the logging function works correctly. These include the test setup file modules/adot/tests/enable_logging/0-setup.tf and the test example modules/adot/tests/enable_logging/1-example.tf. A new README file (modules/adot/tests/enable_logging/README.md) provides details about these tests.
  • Including Logging_Enable Attribute

    • A new attribute logging_enable has been added to the adot_config variable in the variables.tf file. This attribute helps determine if the logging function should be enabled or not.

Copy link

Output

check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check yaml...............................................................Passed
check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
- hook id: terraform_docs
- files were modified by this hook
Detect hardcoded secrets.................................................Passed

1 similar comment
Copy link

Output

check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check yaml...............................................................Passed
check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
- hook id: terraform_docs
- files were modified by this hook
Detect hardcoded secrets.................................................Passed

Copy link
Contributor

@aramkarapetian aramkarapetian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aghamyan44 aghamyan44 merged commit 25506e4 into main Dec 15, 2023
35 checks passed
@aghamyan44 aghamyan44 deleted the DMVP-3125 branch December 15, 2023 14:01
Copy link

🎉 This PR is included in version 2.14.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

Output

check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check yaml...............................................................Passed
check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
- hook id: terraform_docs
- files were modified by this hook
Detect hardcoded secrets.................................................Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants