Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: upgrade react avoid ip #1308

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Fix: upgrade react avoid ip #1308

merged 2 commits into from
Jun 3, 2024

Conversation

dlpzx
Copy link
Contributor

@dlpzx dlpzx commented Jun 3, 2024

Feature or Bugfix

  • Bugfix

Detail

There is a new vulnerability found in the package ip. Similar to the one that we faced a couple of months ago (check this PR). In fact the CVE opened now is the result of the old vulnerability being only partially fixed.

There is not a fixed version and there are no PRs open in the original repo. There is not much activity happening in this repository, so a fix might take some time. At the same time, we do not use this package directly, it is a sub-dependency from react-native packages. Since node_modules/@react-native-community/cli version: 13.6.6, does not use ip, the easiest way for us to avoid this issue is to upgrade react-native packages.

In addition, this PR removes an expired ignore for npm-audit.

Relates

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)?
    • Is the input sanitized?
    • What precautions are you taking before deserializing the data you consume?
    • Is injection prevented by parametrizing queries?
    • Have you ensured no eval or similar functions are used?
  • Does this PR introduce any functionality or component that requires authorization?
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
    • Are you logging failed auth attempts?
  • Are you using or adding any cryptographic features?
    • Do you use a standard proven implementations?
    • Are the used keys controlled by the customer? Where are they stored?
  • Are you introducing any new policies/roles/users?
    • Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dlpzx dlpzx marked this pull request as ready for review June 3, 2024 11:07
@dlpzx dlpzx requested a review from petrkalos June 3, 2024 11:07
@dlpzx dlpzx merged commit 193b304 into main Jun 3, 2024
9 checks passed
@dlpzx dlpzx deleted the fix/upgrade-react-avoid-ip branch June 3, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants