Added customized className for rows #250
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When working with dat.gui, I encountered this use case where there are two set of markers with different colors to show(screenshot attached). The border left bar seems to be a good place for color indications. However, the color scheme for the gui seems to be quite fixed. Thus I modified the code to allow customized className when adding a controller row, I can then overwrite the style in customized CSS.
Use case:
Javascript:
CSS:
I think it's worthwhile to allow some freedom w.r.t the color/style, but not sure if it's the best way to go. Any suggestions would be appreciated!