Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Internal] Add test instructions for external contributors #1073

Merged
merged 2 commits into from
Oct 29, 2024
Merged

[Internal] Add test instructions for external contributors #1073

merged 2 commits into from
Oct 29, 2024

Conversation

hectorcast-db
Copy link
Contributor

@hectorcast-db hectorcast-db commented Oct 29, 2024 •
edited
Loading

Changes

Add test instructions for external contributions. The instructions are meant for Databricks reviewers who will be running the integration tests.

Tests

Temporary added the following target to trigger the workflow

pull_request:
    types: [opened, reopened, synchronize]

and changed the equality in the external check

          if [ "${{ github.event.pull_request.head.repo.full_name }}" == "${{ github.repository }}" ]; then

Result:
Screenshot 2024-10-29 at 10 54 05

@databricks databricks deleted a comment from github-actions bot Oct 29, 2024
@databricks databricks deleted a comment from github-actions bot Oct 29, 2024
pietern
pietern reviewed Oct 29, 2024
View reviewed changes
.github/workflows/external-message.yml Outdated Show resolved Hide resolved
.github/workflows/external-message.yml Outdated Show resolved Hide resolved
renaudhartert-db
renaudhartert-db approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@renaudhartert-db renaudhartert-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM under resolution of Pieter's comments.

mgyucht
mgyucht approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto, thanks for this!

@databricks databricks deleted a comment from github-actions bot Oct 29, 2024
@databricks databricks deleted a comment from github-actions bot Oct 29, 2024
@eng-dev-ecosystem-bot
Copy link
Collaborator

Test Details: go/deco-tests/11572106364

@hectorcast-db hectorcast-db added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit fdd6b16 Oct 29, 2024
12 checks passed
@hectorcast-db hectorcast-db deleted the hectorcast-db/comment-pr branch October 29, 2024 11:45
This was referenced Oct 29, 2024
Merged
Merged
Closed
Merged
Merged
github-merge-queue bot pushed a commit to databricks/cli that referenced this pull request Oct 29, 2024
@hectorcast-db
[Internal] Add test instructions for external contributors (#1863)
20fd401 
## Changes
Add test instructions for external contributors

## Tests
See Go Changes
databricks/databricks-sdk-go#1073
github-merge-queue bot pushed a commit to databricks/databricks-sdk-py that referenced this pull request Oct 30, 2024
@hectorcast-db
[Internal] Add test instructions for external contributors (#804)
87c8dc4 
## Changes
Add test instructions for external contributors

## Tests
See Go Changes
databricks/databricks-sdk-go#1073
github-merge-queue bot pushed a commit to databricks/databricks-sdk-java that referenced this pull request Oct 30, 2024
@hectorcast-db
[Internal] Add test instructions for external contributors (#370)
f847848 
## Changes
Add test instructions for external contributors

## Tests
See Go Changes
databricks/databricks-sdk-go#1073
github-merge-queue bot pushed a commit to databricks/terraform-provider-databricks that referenced this pull request Oct 30, 2024
@hectorcast-db
[Internal] Add test instructions for external contributors (#4169)
dfa6bc0 
## Changes
Add test instructions for external contributors

## Tests
See Go Changes
databricks/databricks-sdk-go#1073
github-merge-queue bot pushed a commit to databricks/databricks-sdk-java that referenced this pull request Oct 30, 2024
@hectorcast-db
[Internal] Add test instructions for external contributors (#370)
2f08742 
## Changes
Add test instructions for external contributors

## Tests
See Go Changes
databricks/databricks-sdk-go#1073
github-merge-queue bot pushed a commit to databricks/databricks-sdk-py that referenced this pull request Oct 30, 2024
@hectorcast-db
[Internal] Add test instructions for external contributors (#804)
52a2955 
## Changes
Add test instructions for external contributors

## Tests
See Go Changes
databricks/databricks-sdk-go#1073
@hectorcast-db hectorcast-db mentioned this pull request Oct 30, 2024
Merged
hectorcast-db added a commit to databricks/databricks-vscode that referenced this pull request Oct 30, 2024
@hectorcast-db
[Internal] Add test instructions for external contributors (#1428)
9a07a90 
## Changes
Add test instructions for external contributors

## Tests
See Go Changes
databricks/databricks-sdk-go#1073
renaudhartert-db added a commit that referenced this pull request Oct 31, 2024
@renaudhartert-db
[Release] Release v0.50.0
83dc1c0 
### Internal Changes

 * Add DCO guidelines ([#1047](#1047)).
 * Add test instructions for external contributors ([#1073](#1073)).
 * Automatically trigger integration tests ([#1067](#1067)).
 * Move templates in the code generator ([#1075](#1075)).
 * Remove unnecessary test ([#1071](#1071)).

### API Changes:

 * Added [w.AibiDashboardEmbeddingAccessPolicy](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#AibiDashboardEmbeddingAccessPolicyAPI) workspace-level service and [w.AibiDashboardEmbeddingApprovedDomains](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#AibiDashboardEmbeddingApprovedDomainsAPI) workspace-level service.
 * Added `AppDeployment` field for [apps.CreateAppDeploymentRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/apps#CreateAppDeploymentRequest).
 * Added `App` field for [apps.CreateAppRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/apps#CreateAppRequest).
 * Added `App` field for [apps.UpdateAppRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/apps#UpdateAppRequest).
 * Added `Table` field for [catalog.CreateOnlineTableRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#CreateOnlineTableRequest).
 * Added `Dashboard` field for [dashboards.CreateDashboardRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#CreateDashboardRequest).
 * Added `Schedule` field for [dashboards.CreateScheduleRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#CreateScheduleRequest).
 * Added `Subscription` field for [dashboards.CreateSubscriptionRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#CreateSubscriptionRequest).
 * Added `Dashboard` field for [dashboards.UpdateDashboardRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#UpdateDashboardRequest).
 * Added `Schedule` field for [dashboards.UpdateScheduleRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#UpdateScheduleRequest).
 * Added `PageToken` field for [oauth2.ListServicePrincipalSecretsRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/oauth2#ListServicePrincipalSecretsRequest).
 * Added `NextPageToken` field for [oauth2.ListServicePrincipalSecretsResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/oauth2#ListServicePrincipalSecretsResponse).
 * Added `IsNoPublicIpEnabled` field for [provisioning.CreateWorkspaceRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/provisioning#CreateWorkspaceRequest).
 * Added `ExternalCustomerInfo` and `IsNoPublicIpEnabled` fields for [provisioning.Workspace](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/provisioning#Workspace).
 * Added `LastUsedDay` field for [settings.TokenInfo](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#TokenInfo).
 * Changed `Create` method for [w.Apps](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/apps#AppsAPI) workspace-level service with new required argument order.
 * Changed `ExecuteMessageQuery` method for [w.Genie](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#GenieAPI) workspace-level service . New request type is [dashboards.GenieExecuteMessageQueryRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#GenieExecuteMessageQueryRequest).
 * Changed `ExecuteMessageQuery` method for [w.Genie](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#GenieAPI) workspace-level service to type `ExecuteMessageQuery` method for [w.Genie](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#GenieAPI) workspace-level service.
 * Changed `Create`, `CreateSchedule`, `CreateSubscription` and `UpdateSchedule` methods for [w.Lakeview](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#LakeviewAPI) workspace-level service with new required argument order.
 * Removed `DeploymentId`, `Mode` and `SourceCodePath` fields for [apps.CreateAppDeploymentRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/apps#CreateAppDeploymentRequest).
 * Removed `Description`, `Name` and `Resources` fields for [apps.CreateAppRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/apps#CreateAppRequest).
 * Removed `Description` and `Resources` fields for [apps.UpdateAppRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/apps#UpdateAppRequest).
 * Removed `Name` and `Spec` fields for [catalog.CreateOnlineTableRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#CreateOnlineTableRequest).
 * Removed `DisplayName`, `ParentPath`, `SerializedDashboard` and `WarehouseId` fields for [dashboards.CreateDashboardRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#CreateDashboardRequest).
 * Removed `CronSchedule`, `DisplayName` and `PauseStatus` fields for [dashboards.CreateScheduleRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#CreateScheduleRequest).
 * Removed `Subscriber` field for [dashboards.CreateSubscriptionRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#CreateSubscriptionRequest).
 * Removed `DisplayName`, `Etag`, `SerializedDashboard` and `WarehouseId` fields for [dashboards.UpdateDashboardRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#UpdateDashboardRequest).
 * Removed `CronSchedule`, `DisplayName`, `Etag` and `PauseStatus` fields for [dashboards.UpdateScheduleRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#UpdateScheduleRequest).
 * Removed `PrevPageToken` field for [jobs.Run](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#Run).

OpenAPI SHA: 25b2478e5a18c888f0d423249abde5499dc58424, Date: 2024-10-31
@renaudhartert-db renaudhartert-db mentioned this pull request Oct 31, 2024
Merged
hectorcast-db added a commit to databricks/databricks-sdk-java that referenced this pull request Oct 31, 2024
@hectorcast-db
[Internal] Add test instructions for external contributors (#370)
fb64672 
Add test instructions for external contributors

See Go Changes
databricks/databricks-sdk-go#1073
hectorcast-db added a commit to databricks/databricks-sdk-java that referenced this pull request Oct 31, 2024
@hectorcast-db
[Internal] Add test instructions for external contributors (#370)
3ac5067 
Add test instructions for external contributors

See Go Changes
databricks/databricks-sdk-go#1073
github-merge-queue bot pushed a commit that referenced this pull request Oct 31, 2024
@renaudhartert-db
[Release] Release v0.50.0 (#1077)
e9314bd 
### Internal Changes

* Add DCO guidelines
([#1047](#1047)).
* Add test instructions for external contributors
([#1073](#1073)).
* Automatically trigger integration tests
([#1067](#1067)).
* Move templates in the code generator
([#1075](#1075)).
* Remove unnecessary test
([#1071](#1071)).


### API Changes:

* Added
[w.AibiDashboardEmbeddingAccessPolicy](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#AibiDashboardEmbeddingAccessPolicyAPI)
workspace-level service and
[w.AibiDashboardEmbeddingApprovedDomains](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#AibiDashboardEmbeddingApprovedDomainsAPI)
workspace-level service.
* Added `AppDeployment` field for
[apps.CreateAppDeploymentRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/apps#CreateAppDeploymentRequest).
* Added `App` field for
[apps.CreateAppRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/apps#CreateAppRequest).
* Added `App` field for
[apps.UpdateAppRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/apps#UpdateAppRequest).
* Added `Table` field for
[catalog.CreateOnlineTableRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#CreateOnlineTableRequest).
* Added `Dashboard` field for
[dashboards.CreateDashboardRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#CreateDashboardRequest).
* Added `Schedule` field for
[dashboards.CreateScheduleRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#CreateScheduleRequest).
* Added `Subscription` field for
[dashboards.CreateSubscriptionRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#CreateSubscriptionRequest).
* Added `Dashboard` field for
[dashboards.UpdateDashboardRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#UpdateDashboardRequest).
* Added `Schedule` field for
[dashboards.UpdateScheduleRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#UpdateScheduleRequest).
* Added `PageToken` field for
[oauth2.ListServicePrincipalSecretsRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/oauth2#ListServicePrincipalSecretsRequest).
* Added `NextPageToken` field for
[oauth2.ListServicePrincipalSecretsResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/oauth2#ListServicePrincipalSecretsResponse).
* Added `IsNoPublicIpEnabled` field for
[provisioning.CreateWorkspaceRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/provisioning#CreateWorkspaceRequest).
* Added `ExternalCustomerInfo` and `IsNoPublicIpEnabled` fields for
[provisioning.Workspace](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/provisioning#Workspace).
* Added `LastUsedDay` field for
[settings.TokenInfo](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#TokenInfo).
* Changed `Create` method for
[w.Apps](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/apps#AppsAPI)
workspace-level service with new required argument order.
* Changed `ExecuteMessageQuery` method for
[w.Genie](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#GenieAPI)
workspace-level service . New request type is
[dashboards.GenieExecuteMessageQueryRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#GenieExecuteMessageQueryRequest).
* Changed `ExecuteMessageQuery` method for
[w.Genie](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#GenieAPI)
workspace-level service to type `ExecuteMessageQuery` method for
[w.Genie](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#GenieAPI)
workspace-level service.
* Changed `Create`, `CreateSchedule`, `CreateSubscription` and
`UpdateSchedule` methods for
[w.Lakeview](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#LakeviewAPI)
workspace-level service with new required argument order.
* Removed `PrevPageToken` field for
[jobs.Run](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#Run).

The following fields are now nested in the request:

* Removed `DeploymentId`, `Mode` and `SourceCodePath` fields for
[apps.CreateAppDeploymentRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/apps#CreateAppDeploymentRequest).
* Removed `Description`, `Name` and `Resources` fields for
[apps.CreateAppRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/apps#CreateAppRequest).
* Removed `Description` and `Resources` fields for
[apps.UpdateAppRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/apps#UpdateAppRequest).
* Removed `Name` and `Spec` fields for
[catalog.CreateOnlineTableRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#CreateOnlineTableRequest).
* Removed `DisplayName`, `ParentPath`, `SerializedDashboard` and
`WarehouseId` fields for
[dashboards.CreateDashboardRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#CreateDashboardRequest).
* Removed `CronSchedule`, `DisplayName` and `PauseStatus` fields for
[dashboards.CreateScheduleRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#CreateScheduleRequest).
* Removed `Subscriber` field for
[dashboards.CreateSubscriptionRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#CreateSubscriptionRequest).
* Removed `DisplayName`, `Etag`, `SerializedDashboard` and `WarehouseId`
fields for
[dashboards.UpdateDashboardRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#UpdateDashboardRequest).
* Removed `CronSchedule`, `DisplayName`, `Etag` and `PauseStatus` fields
for
[dashboards.UpdateScheduleRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#UpdateScheduleRequest).

OpenAPI SHA: 25b2478e5a18c888f0d423249abde5499dc58424, Date: 2024-10-31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietern pietern pietern left review comments

@renaudhartert-db renaudhartert-db renaudhartert-db approved these changes

@mgyucht mgyucht mgyucht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hectorcast-db @eng-dev-ecosystem-bot @pietern @mgyucht @renaudhartert-db